tests/misc/coreutils.sh: Fail with invalid binary name #10258

oech3 · 2026-01-15T08:25:46Z

Fixes #10244
Also covers some (but no all of) use case for symlinking binary to /bin/false.

github-actions · 2026-01-15T08:36:27Z

GNU testsuite comparison:

GNU test failed: tests/env/env. tests/env/env is passing on 'main'. Maybe you have to rebase?

codspeed-hq · 2026-01-15T08:57:07Z

CodSpeed Performance Report

Merging this PR will not alter performance

_{Comparing oech3:core-1 (5cf5534) with main (7654075)¹}

Summary

✅ 34 untouched benchmarks
⏩ 286 skipped benchmarks²

No successful run was found on main (62c2007) during the generation of this report, so 7654075 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
286 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

github-actions · 2026-01-15T09:07:30Z

GNU testsuite comparison:

GNU test failed: tests/env/env. tests/env/env is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)

github-actions · 2026-01-15T09:22:15Z

GNU testsuite comparison:

GNU test failed: tests/env/env. tests/env/env is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/shuf/shuf-reservoir (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/sort/sort-stale-thread-mem (fails in this run but passes in the 'main' branch)

github-actions · 2026-01-15T10:10:27Z

GNU testsuite comparison:

GNU test failed: tests/env/env. tests/env/env is passing on 'main'. Maybe you have to rebase?

oech3 · 2026-01-15T13:10:53Z

src/bin/coreutils.rs

            Some(OsString::from(util))
-        } else {
-            // unmatched binary name => regard as multi-binary container and advance argument list
+        } else if binary_as_util.ends_with("coreutils") || binary_as_util.ends_with("box") {


I don't like to have .ends_with("box") in the binary just for test suite. Should be covered by shebang wrapper (at different PR).

shebang does not work...

src/bin/coreutils.rs

github-actions · 2026-01-18T11:20:33Z

GNU testsuite comparison:

GNU test failed: tests/env/env. tests/env/env is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/misc/coreutils. tests/misc/coreutils is passing on 'main'. Maybe you have to rebase?

sylvestre · 2026-01-18T11:24:02Z

GNU test failed: tests/misc/coreutils. tests/misc/coreutils is passing on 'main'. Maybe you have to rebase?

this should be fixed before

Setup $ ln -nsf src/coreutils foo Before $ ./foo; echo $? foo: unknown program ‘foo’ Try './foo --help' for more information. 1 ./foo --version; echo $? coreutils (GNU coreutils) 9.9.172-01993 0 After $ ./foo; echo $? coreutils: unknown program 'foo' 1 $ ./foo --version; echo $? coreutils: unknown program 'foo' 1 * src/coreutils.c (main): Don't process options if we don't know they're intended for the multi-call binary. Otherwise `foo --version` would return true, even though foo was symlinked to the multi-call binary, but not supported. * tests/misc/coreutils.sh: Add test cases. * NEWS: Mention the change in behavior.

github-actions · 2026-01-18T13:54:43Z

GNU testsuite comparison:

GNU test failed: tests/env/env. tests/env/env is passing on 'main'. Maybe you have to rebase?

oech3 · 2026-01-18T14:16:49Z

https://github.com/uutils/coreutils/actions/runs/21112728722/job/60713727150?pr=10258#step:11:228
OK.

sylvestre · 2026-01-18T15:45:19Z

are you sure?

2026-01-18T13:51:53.7896007Z FAIL: tests/env/env
2026-01-18T13:51:53.7896197Z ===================
2026-01-18T13:51:53.7896307Z 
2026-01-18T13:51:53.7896395Z simple_echo ./simple_echo
2026-01-18T13:51:53.7896633Z error: unexpected argument '---' found
2026-01-18T13:51:53.7896815Z 
2026-01-18T13:51:53.7896918Z   tip: to pass '---' as a value, use '-- ---'
2026-01-18T13:51:53.7897104Z 
2026-01-18T13:51:53.7897250Z Usage: env [OPTION]... [-] [NAME=VALUE]... [COMMAND [ARG]...]
2026-01-18T13:51:53.7897483Z 
2026-01-18T13:51:53.7897575Z For more information, try '--help'.
2026-01-18T13:51:53.7897856Z env: use -[v]S to pass options in shebang lines
2026-01-18T13:51:53.7898225Z error: a value is required for '--unset <NAME>' but none was supplied
2026-01-18T13:51:53.7898490Z 
2026-01-18T13:51:53.7898587Z For more information, try '--help'.
2026-01-18T13:51:53.7898853Z env: use -[v]S to pass options in shebang lines
2026-01-18T13:51:53.7899146Z nice: .: Permission denied (os error 13)
2026-01-18T13:51:53.7899417Z env: '.': Permission denied
2026-01-18T13:51:53.7899652Z env: 'no_such': No such file or directory
2026-01-18T13:51:53.7899940Z env: use -[v]S to pass options in shebang lines
2026-01-18T13:51:53.7900242Z env: 'also_unlikely': No such file or directory
2026-01-18T13:51:53.7900819Z env: use -[v]S to pass options in shebang lines
2026-01-18T13:51:53.7901184Z env: '--': No such file or directory
2026-01-18T13:51:53.7901455Z env: use -[v]S to pass options in shebang lines
2026-01-18T13:51:53.7901736Z env: cannot unset 'a=b': Invalid argument
2026-01-18T13:51:53.7902010Z env: cannot unset '': Invalid argument
2026-01-18T13:51:53.7902437Z env: cannot change directory to 'empty/nonexistent': No such file or directory (os error 2)
2026-01-18T13:51:53.7902878Z FAIL tests/env/env.sh (exit status: 1)

oech3 · 2026-01-18T15:47:06Z

No. needs investigation

* tests/misc/coreutils.sh: Be more flexibile by using `command -v` to identify the binary to be executed, rather than linking directly to the built binary.

github-actions · 2026-01-18T16:42:14Z

GNU testsuite comparison:

GNU test failed: tests/env/env. tests/env/env is passing on 'main'. Maybe you have to rebase?

oech3 marked this pull request as draft January 15, 2026 08:31

oech3 force-pushed the core-1 branch 3 times, most recently from e9b9baa to ddd1f27 Compare January 15, 2026 08:55

oech3 force-pushed the core-1 branch from ddd1f27 to 3786101 Compare January 15, 2026 09:08

oech3 mentioned this pull request Jan 15, 2026

coreutils: Should we really support --coreutils-prog=yes too? #9575

Closed

oech3 force-pushed the core-1 branch from 3786101 to 963f649 Compare January 15, 2026 09:51

oech3 marked this pull request as ready for review January 15, 2026 10:43

oech3 commented Jan 15, 2026

View reviewed changes

oech3 force-pushed the core-1 branch 2 times, most recently from 572a08f to a7da462 Compare January 15, 2026 16:07

oech3 changed the title ~~coreutils: Fail with invalid binary name~~ tests/misc/coreutils.sh: Fail with invalid binary name Jan 15, 2026

oech3 force-pushed the core-1 branch 7 times, most recently from 657c5e7 to f7625bd Compare January 16, 2026 10:54

sylvestre reviewed Jan 17, 2026

View reviewed changes

src/bin/coreutils.rs Outdated Show resolved Hide resolved

oech3 added 3 commits January 18, 2026 01:24

coreutils: Fail with invalid binary name

ef3f9eb

coreutils: Support the name *box as a workaround for *box test suite

2cf731b

Use validation::not_found to print error message and exit

0d4378d

oech3 force-pushed the core-1 branch from 321b299 to 0d4378d Compare January 17, 2026 16:24

Resolve conflict

dd70a52

oech3 force-pushed the core-1 branch from 9dbb3a0 to dd70a52 Compare January 18, 2026 11:05

This comment was marked as resolved.

Sign in to view

oech3 marked this pull request as draft January 18, 2026 11:57

Merge branch 'main' into core-1

4ff3c89

oech3 marked this pull request as ready for review January 18, 2026 14:16

oech3 marked this pull request as draft January 18, 2026 15:46

oech3 referenced this pull request in coreutils/coreutils Jan 18, 2026

tests: use command -v to identify binary

fcaa3a3

* tests/misc/coreutils.sh: Be more flexibile by using `command -v` to identify the binary to be executed, rather than linking directly to the built binary.

Merge branch 'main' into core-1

0f80b3e

oech3 force-pushed the core-1 branch from 4bbe164 to 0f80b3e Compare January 18, 2026 17:35

Merge branch 'main' into core-1

e265fa7

oech3 force-pushed the core-1 branch from 5cf5534 to e265fa7 Compare January 18, 2026 18:08

Merge branch 'main' into core-1

afaff45

Uh oh!

tests/misc/coreutils.sh: Fail with invalid binary name #10258

Are you sure you want to change the base?

tests/misc/coreutils.sh: Fail with invalid binary name #10258

Conversation

oech3 commented Jan 15, 2026

Uh oh!

github-actions bot commented Jan 15, 2026

Uh oh!

codspeed-hq bot commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging this PR will not alter performance

Summary

Footnotes

Uh oh!

github-actions bot commented Jan 15, 2026

Uh oh!

github-actions bot commented Jan 15, 2026

Uh oh!

github-actions bot commented Jan 15, 2026

Uh oh!

oech3 Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

oech3 Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Jan 18, 2026

Uh oh!

This comment was marked as resolved.

sylvestre commented Jan 18, 2026

Uh oh!

This comment was marked as resolved.

github-actions bot commented Jan 18, 2026

Uh oh!

oech3 commented Jan 18, 2026

Uh oh!

sylvestre commented Jan 18, 2026

Uh oh!

oech3 commented Jan 18, 2026

Uh oh!

github-actions bot commented Jan 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codspeed-hq bot commented Jan 15, 2026 •

edited

Loading