Skip to content

Conversation

@oech3
Copy link
Contributor

@oech3 oech3 commented Jan 15, 2026

Accept ginstall. Actually closes #9237

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 15, 2026

Merging this PR will degrade performance by 25%

❌ 8 regressed benchmarks
✅ 274 untouched benchmarks
⏩ 38 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Memory sort_accented_data[500000] 22.1 MB 28.3 MB -21.76%
Memory sort_mixed_data[500000] 22.5 MB 27.2 MB -17.18%
Memory sort_long_line[160000] 724.4 KB 965.9 KB -25%
Memory sort_ascii_only[500000] 22.2 MB 28.3 MB -21.74%
Memory sort_key_field[500000] 45.8 MB 51.7 MB -11.4%
Memory sort_case_sensitive[500000] 16.9 MB 17.9 MB -5.72%
Simulation cp_large_file[16] 369.8 µs 384.6 µs -3.85%
Memory cp_large_file[16] 107.6 KB 116.9 KB -8%

Comparing oech3:core-freepfx (084ab30) with main (799de29)

Open in CodSpeed

Footnotes

  1. 38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@oech3
Copy link
Contributor Author

oech3 commented Jan 16, 2026

Is performance regression real?

@sylvestre
Copy link
Contributor

Nope. I think we have instabilities with these tests

@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)

@sylvestre sylvestre merged commit d72d6f7 into uutils:main Jan 18, 2026
158 of 159 checks passed
@oech3 oech3 deleted the core-freepfx branch January 18, 2026 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

coreutils: PROG_PREFIX needs -, =, or _

2 participants