ci: ensure test failures are caught in coverage script and fix them #10286
+27
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test assumed that the process always has exactly one TTY in its file descriptors. In CI environments or when running tests without a terminal attached, there is no controlling TTY, causing the test to fail with `assert_eq!(result.len(), 1)` when `result.len()` is 0.
- Add `set -o pipefail` to ensure test failures from cargo nextest are detected even when output is piped through grep - Look for llvm-profdata in the nightly toolchain (nightly-gnu) since that's what the script uses for coverage builds - Add helpful error message if llvm-profdata is not found
Add LANG=C environment variable to the FIFO tests alongside LC_ALL=C and LANGUAGE=C. The Fluent localization system checks multiple locale environment variables, and all three are needed to ensure English output in the test assertions.
The previous implementation checked if Errno::last() was UnknownErrno to determine success, but this is incorrect because errno is not cleared on success. A previous syscall could have set errno to a value like ENOENT, causing getsid to incorrectly report an error. The correct pattern is to check if the result is -1, which is what getsid returns on error per POSIX.
CodSpeed Performance ReportMerging this PR will degrade performance by 4.25%Comparing Summary
Performance Changes
Footnotes
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of #10219