Skip to content

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze marked this pull request as ready for review January 19, 2026 02:16
@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/ptx/ptx-overrun is no longer failing!

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 19, 2026

CodSpeed Performance Report

Merging this PR will degrade performance by 15.41%

Comparing xtqqczze:clippy/needless_continue (d9ea635) with main (356567e)

Summary

⚡ 6 improved benchmarks
❌ 2 regressed benchmarks
✅ 274 untouched benchmarks
⏩ 38 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Memory sort_long_line[160000] 724.5 KB 856.4 KB -15.41%
Memory sort_accented_data[500000] 25.5 MB 21.6 MB +18.11%
Memory sort_mixed_data[500000] 25.8 MB 22.4 MB +15.24%
Memory sort_numeric[500000] 48.7 MB 46 MB +5.83%
Memory sort_unique_locale[500000] 36.9 MB 33 MB +11.83%
Memory sort_key_field[500000] 32.8 MB 29.2 MB +12.53%
Memory sort_ascii_only[500000] 25.5 MB 21.9 MB +16.7%
Memory dd_copy_partial 127.7 KB 132.1 KB -3.29%

Footnotes

  1. 38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant