Get 'test' working properly with acls and supplementary groups #9149
+279
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging this PR will not alter performance
Comparing 
Footnotes
|
|
GNU testsuite comparison: |
sylvestre
requested changes
Dec 26, 2025
Contributor
sylvestre
left a comment
sylvestre
left a comment
There was a problem hiding this comment.
dunno if you saw it but many jobs are failing, this is why it hasn't been reviewed yet
jefft
force-pushed
the
fix/8960-9147-test-work-with-acls-and-supplementary-groups
branch
from
d56a7d6 to
e06edcb
Compare
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
jefft
force-pushed
the
fix/8960-9147-test-work-with-acls-and-supplementary-groups
branch
2 times, most recently
from
a7881d7 to
dc664b3
Compare
jefft
force-pushed
the
fix/8960-9147-test-work-with-acls-and-supplementary-groups
branch
2 times, most recently
from
24c7c88 to
72aa2ee
Compare
|
GNU testsuite comparison: |
jefft
force-pushed
the
fix/8960-9147-test-work-with-acls-and-supplementary-groups
branch
2 times, most recently
from
f8a5524 to
7fbfd9f
Compare
|
GNU testsuite comparison: |
Run with: cargo test --test tests test_permission_with_acl
…ls#9147 Run with: cargo test --test tests test_permission_with_supplementary_group
Replace manual permission checking logic with platform-specific libc functions that properly handle supplementary groups and ACLs: - Linux, Hurd, Redox, Cygwin, Solaris, Illumos: euidaccess() - FreeBSD: eaccess() - macOS, iOS, NetBSD, OpenBSD, DragonFly: faccessat() with AT_EACCESS - Android: faccessat() - Other OSes: fall back to libc:access() These functions delegate permission checks to the kernel, which correctly evaluates all of the user's group memberships (both primary and supplementary), as well as ACLs and other advanced permission features. Fixes uutils#8960 Fixes uutils#9147
jefft
force-pushed
the
fix/8960-9147-test-work-with-acls-and-supplementary-groups
branch
from
7fbfd9f to
7302d2d
Compare
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8960 and #9147. Delegate to libc
euidaccessto avoid bugs (#9147) and respect ACLs (#8960).Note, the tests are independent commits that can be applied first, where they should fail before the 'fix' commit is applied. Run the tests with:
Warning: code is partly Claude-generated as I'm not that familiar with Rust.