ZTWIM GA #85
Merged
ZTWIM GA #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Block <andy.block@gmail.com>
mlorenzofr
reviewed
Dec 18, 2025
| federatesWith: | ||
| {{- toYaml .Values.spire.server.federation.federatesWith | nindent 6 }} | ||
| {{- end }} | ||
| managedRoute: {{ (.Values.spire.server.federation.ingress.operatorManaged | default false) | quote }} |
Collaborator
There was a problem hiding this comment.
If we are inside an if conditional block, where the value of .Values.spire.server.federation.ingress.operatorManaged is equal to "true", does the clause "| default false" clause make sense?
mlorenzofr
reviewed
Dec 18, 2025
Collaborator
mlorenzofr
left a comment
mlorenzofr
left a comment
There was a problem hiding this comment.
LGTM
The deployment to a fresh cluster worked properly
Just a small comment of no great importance
Collaborator
|
LGTM! Tested with ODF operator set to stable-4.20 with RHTAS, RHTPA, QUAY enabled. |
mlorenzofr
pushed a commit
to mlorenzofr/layered-zero-trust
that referenced
this pull request
Dec 18, 2025
Signed-off-by: Andrew Block <andy.block@gmail.com>
mlorenzofr
pushed a commit
to mlorenzofr/layered-zero-trust
that referenced
this pull request
Dec 18, 2025
Signed-off-by: Andrew Block <andy.block@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZTWIM GA