feat: BYO container registry support#99
Open
minmzzhang wants to merge 2 commits intovalidatedpatterns:mainfrom
Open
feat: BYO container registry support#99minmzzhang wants to merge 2 commits intovalidatedpatterns:mainfrom
minmzzhang wants to merge 2 commits intovalidatedpatterns:mainfrom
Conversation
Restructure registry configuration to support three deployment states:
- Fresh install: No registry configured (both disabled by default)
- Built-in Quay: quay.enabled=true uses hub/infra/quay/ vault path
- External/BYO: externalRegistry.enabled=true uses hub/infra/registry/ path
Changes:
- Add externalRegistry.enabled flag to supply-chain and qtodo charts
- Separate vault paths for built-in Quay vs external registry
- Templates conditionally select vault path based on enabled flags
- Update supply-chain.md with BYO registry setup instructions
- Add helm template method and oc monitoring commands to supply-chain.md
- Follow VP best practice: external registry secrets in local ~/values-secret.yaml
To enable supply-chain:
1. Uncomment openshift-pipelines namespace and subscription
2. Uncomment supply-chain vault role (JWT auth)
3. Configure registry (BYO or built-in Quay) in application overrides
- For BYO registry:
- Set externalRegistry.enabled=true and configure registry settings
- Add registry credentials to ~/values-secret.yaml
- For built-in Quay:
- Enable openshift-storage namespace
- Enable ODF, NooBaa MCG
- Enable Quay operator subscription, quay-registry application
4. RHTAS (signing): Enable rhtas-operator subscription and trusted-artifact-signer namespace
5. RHTPA (SBOM): Enable rhtpa-operator subscription, ODF, NooBaa, and trusted-profile-analyzer
Signed-off-by: Min Zhang <minzhang@redhat.com>
Collaborator
Author
|
This is the same PR of #98, which got accidentally closed. |
Refactor supply-chain and qtodo charts to use a single, option-agnostic
registry configuration instead of separate per-registry blocks.
Registry options (configure one in values-hub.yaml):
- Option 1: Built-in Quay Registry
- Option 2: BYO/External Registry (quay.io, ghcr.io, etc.)
- Option 3: Embedded OCP Image Registry
Key changes:
Supply-chain chart:
* Unified registry.* parameters (domain, org, user, vaultPath, passwordVaultKey)
* Use tpl function to resolve template expressions in registry.domain values
passed as --set parameters from the validated patterns framework
* Embedded OCP registry automation (registry.embeddedOCP.ensureImageNamespaceRBAC):
- Auto-create image namespace matching registry.org
- Grant pipeline SA system:image-builder via RoleBinding
- Enable default route on OCP image registry via Kubernetes API
(curl-based Job using ServiceAccount token, no oc CLI dependency)
* ArgoCD hook annotations on the route-enabler Job (Sync + HookSucceeded)
* Rename qtodo-registry-pass to qtodo-quay-pass for clarity
Qtodo chart:
* Unified app.images.main.registry.* parameters
* Use tpl function in registry-external-secret.yaml for domain resolution
ztvp-certificates chart:
* Node-level image pull trust for kubelet (imagePullTrust.*)
* Create ConfigMap with ingress CA per registry hostname in openshift-config
* Patch image.config.openshift.io/cluster additionalTrustedCA
* RBAC for patching image.config.openshift.io resources
Documentation: * Comprehensive supply-chain.md with configuration steps for all three
registry options, vault paths, and example overrides
* Updated values-secret.yaml.template with registry credential examples
Signed-off-by: Min Zhang <minzhang@redhat.com>
minmzzhang
force-pushed
the
byo-container-registry-fresh-install
branch
from
19faccc to
b1203c1
Compare
minmzzhang
requested review from
mlorenzofr and
sabre1041
and removed request for
sabre1041
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: BYO container registry support
feat: unified registry configuration with multi-registry support
Refactor supply-chain and qtodo charts to use a single, option-agnostic
registry configuration instead of separate per-registry blocks.
Registry options (configure one in values-hub.yaml):
Key changes:
Supply-chain chart:
passed as --set parameters from the validated patterns framework
(curl-based Job using ServiceAccount token, no oc CLI dependency)
Qtodo chart:
ztvp-certificates chart:
Documentation:
registry options, vault paths, and example overrides
Signed-off-by: Min Zhang minzhang@redhat.com