Update v1 branch #71
Merged
Update v1 branch #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids network activity when we check for the oc client
$ strace -f -e trace=network -y oc version 2>&1 | grep -e socket -e connect
[pid 31622] socket(AF_UNIX, SOCK_STREAM|SOCK_CLOEXEC|SOCK_NONBLOCK, 0) = 4<socket:[157959]>
[pid 31622] connect(4<socket:[157959]>, {sa_family=AF_UNIX, sun_path="/run/systemd/resolve/io.systemd.Resolve"}, 42) = -1 ENOENT (No such file or directory)
[pid 31622] socket(AF_INET, SOCK_DGRAM|SOCK_CLOEXEC|SOCK_NONBLOCK, IPPROTO_IP) = 4<socket:[157960]>
[pid 31622] setsockopt(4<socket:[157960]>, SOL_IP, IP_RECVERR, [1], 4) = 0
[pid 31622] connect(4<socket:[157960]>, {sa_family=AF_INET, sin_port=htons(53), sin_addr=inet_addr("172.16.15.254")}, 16) = 0
[pid 31622] sendmmsg(4<socket:[157960]>, [{msg_hdr={msg_name=NULL, msg_namelen=0, msg_iov=[{iov_base="Ol\1\0\0\1\0\0\0\0\0\0\3api\7mcg-hub\3aws\21val"..., iov_len=54}], msg_iovlen=1, msg_controllen=0, msg_flags=0}, msg_len=54}, {msg_hdr={msg_name=NULL, msg_namelen=0, msg_iov=[{iov_base="\253o\1\0\0\1\0\0\0\0\0\0\3api\7mcg-hub\3aws\21val"..., iov_len=54}], msg_iovlen=1, msg_controllen=0, msg_flags=0}, msg_len=54}], 2, MSG_NOSIGNAL) = 2
[pid 31622] recvfrom(4<socket:[157960]>, "\253o\201\200\0\1\0\0\0\1\0\0\3api\7mcg-hub\3aws\21val"..., 2048, 0, {sa_family=AF_INET, sin_port=htons(53), sin_addr=inet_addr("172.16.15.254")}, [28 => 16]) = 163
[pid 31622] recvfrom(4<socket:[157960]>, "Ol\201\200\0\1\0\1\0\0\0\0\3api\7mcg-hub\3aws\21val"..., 65536, 0, {sa_family=AF_INET, sin_port=htons(53), sin_addr=inet_addr("172.16.15.254")}, [28 => 16]) = 70
[pid 31622] socket(AF_INET, SOCK_STREAM|SOCK_CLOEXEC|SOCK_NONBLOCK, IPPROTO_IP) = 4<socket:[150273]>
[pid 31622] connect(4<socket:[150273]>, {sa_family=AF_INET, sin_port=htons(6443), sin_addr=inet_addr("35.181.252.216")}, 16) = -1 EINPROGRESS (Operation now in progress)
[pid 31624] getsockopt(4<socket:[150273]>, SOL_SOCKET, SO_ERROR, [0], [4]) = 0
[pid 31624] getpeername(4<socket:[150273]>, {sa_family=AF_INET, sin_port=htons(6443), sin_addr=inet_addr("35.181.252.216")}, [112 => 16]) = 0
[pid 31624] getsockname(4<socket:[150273]>, {sa_family=AF_INET, sin_port=htons(52090), sin_addr=inet_addr("172.16.0.4")}, [112 => 16]) = 0
[pid 31624] setsockopt(4<socket:[150273]>, SOL_TCP, TCP_NODELAY, [1], 4) = 0
[pid 31624] setsockopt(4<socket:[150273]>, SOL_SOCKET, SO_KEEPALIVE, [1], 4) = 0
[pid 31624] setsockopt(4<socket:[150273]>, SOL_TCP, TCP_KEEPIDLE, [30], 4) = 0
[pid 31624] setsockopt(4<socket:[150273]>, SOL_TCP, TCP_KEEPINTVL, [15], 4) = 0
[pid 31624] setsockopt(4<socket:[150273]>, SOL_TCP, TCP_KEEPCNT, [9], 4) = 0
$ strace -f -e trace=network -y oc version --client=true 2>&1 | grep -e socket -e connect
$
Do not poke the network when checking for the oc cli
Contributor
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.