Added a hook for post_auth #218
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrypol
reviewed
Nov 29, 2025
| feature = "min-redis-compatibility-version-7-2", | ||
| feature = "min-valkey-compatibility-version-8-0" | ||
| )))] | ||
| compile_error!("Post-auth callbacks require Redis 7.2 or Valkey 8.0 and above"); |
Collaborator
There was a problem hiding this comment.
wouldn't this work on Valkey 7.2 as well?
Contributor
Author
There was a problem hiding this comment.
it would, i'll update it
dmitrypol
reviewed
Nov 29, 2025
| feature = "min-valkey-compatibility-version-8-0" | ||
| ))] | ||
| unsafe { | ||
| $crate::raw::RedisModule_RegisterAuthCallback.expect("RedisModule_RegisterAuthCallback should exist on Redis/Valkey 7.0 and above")($ctx, Some([<__do_post_auth_ $module_name _ $post_auth_callback>])) |
Collaborator
There was a problem hiding this comment.
shouldn't this be Redis/Valkey 7.2?
dmitrypol
reviewed
Nov 29, 2025
| ) -> std::os::raw::c_int { | ||
| let context = $crate::Context::new(ctx); | ||
| let ctx_ptr = unsafe { std::ptr::NonNull::new_unchecked(ctx) }; | ||
| let username_rs = $crate::ValkeyString::new(Some(ctx_ptr), username); |
Collaborator
There was a problem hiding this comment.
what does username_rs stand for?
Contributor
Author
There was a problem hiding this comment.
username_"rust" since Im converting from the unsafe C pointer
Collaborator
|
interesting idea, let's talk more next week |
dmitrypol
reviewed
Nov 29, 2025
| @@ -0,0 +1,34 @@ | |||
| use std::sync::{LazyLock, Mutex}; | |||
Collaborator
There was a problem hiding this comment.
can we add integration test for this?
Contributor
Author
There was a problem hiding this comment.
I have added examples, not sure how I can do an integ test for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new hook to the macro.rs, allowing module devs to register callbacks that are invoked after authentication completes. The hook provides both the previous and new username, enabling post-auth logic such as auditing, logging, or user state management.