Improve DMX RX #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DMX can contain idle periods between slots (MTBS), and then resume. The DMX reception code was treating idle as the end of the frame, this meant that some older, slightly slower, or even radio based equipment; transmission sources would likely only be part decoded. For "dimmer data" (start code 0), this change now treats the break of the next frame as the end of the previous. To combat potentially processing the last frame data as it's changing with the next, a double buffer system is now used. The magic number slot count flag has also been cleaned up.
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DMX can contain idle periods between slots (MTBS), and then resume. The DMX reception code was treating idle as the end of the frame, this meant that some older, slightly slower, or even radio based equipment; transmission sources would likely only be part decoded.
For "dimmer data" (start code 0), this change now treats the break of the next frame as the end of the previous.
To combat potentially processing the last frame data as it's changing with the next, a double buffer system is now used.
The magic number slot count flag has also been cleaned up.