vcc: New VPI_Probe_Cmp function #4418
Merged
+32
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dridi
reviewed
Nov 27, 2025
Member
|
Not sure if there are other good reasons for the VPI function, but since 7a88cab the main motivation should be gone? |
Member
|
Ah, I see it now: The |
Member
|
I wonder if we should catch the tautology/contradiction in vcc: for edit: Or should we just not do this and keep the compiler error, because such a tautology might be a mistake? |
nigoroll
pushed a commit
to nigoroll/varnish-cache
that referenced
this pull request
Nov 28, 2025
Committer edited: Taken from varnishcache#4418
Member
Author
|
Bugwash:
|
This is just a wrapper around pointers comparison, it avoids C-compiler failures like: error: self-comparison always evaluates to true error: array comparison always evaluates to false Fixes: varnishcache#4410
nigoroll
reviewed
Dec 2, 2025
nigoroll
approved these changes
Dec 3, 2025
Member
nigoroll
left a comment
nigoroll
left a comment
There was a problem hiding this comment.
my fetish asks for a static inline, but other than that +1
nigoroll
added a commit
that referenced
this pull request
Dec 3, 2025
The compound literal is not supported as a constant expression by older compilers, and trying to avoid it (by defining the probe as a struct literal and then taking a pointer to it) comes with another set of problems around unreferenced symbols. So all in all I must say that the single element array "hack" has many more benefits than were apparent to me and I now changed my mind that they actually are, objectively, the better solution - except for the fact that arrays can not be compared, but that will be fixed with #4418. This reverts commit 7a88cab. Ref #4418 Ref #4410
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a wrapper around probes pointers comparison, it avoids C-compiler failures like:
error: self-comparison always evaluates to true
error: array comparison always evaluates to false
Fixes: #4410
And should also fix the failing test case in master branch.