Add std.rfc_ttl() #4427
Add std.rfc_ttl() #4427
Conversation
|
this is massively welcome. But maybe we should also offer the opposite? i.e. modify the headers to match the |
Yes, some standard function to create |
nigoroll
force-pushed
the
std.rfc_ttl
branch
from
e615ed2 to
be7107a
Compare
|
I have updated the PR to also allow |
|
OK with me. |
SashankBhamidi
left a comment
SashankBhamidi
left a comment
There was a problem hiding this comment.
Hi, I've had a look at your pull request and I have a few suggestions. I'm new to this codebase, so please feel free to correct me if I'm wrong.
Overall, I think this is a great addition to the std VMOD.
From the added documentation: Re-calculate the object timers (``beresp.ttl``, ``beresp.grace`` and ``beresp.keep``) based on the current state of ``beresp`` as if it had been processed by core code before ``vcl_backend_response`` was called. This does not change ``beresp.uncacheable``. This is useful to get the default ttl calculations after modifications of relevant properties like ``beresp.status``, ``beresp.http.Date``, ``beresp.http.Age`` or ``beresp.http.Cache-Control``. Documentation details polished by SashankBhamidi, thank you.
nigoroll
force-pushed
the
std.rfc_ttl
branch
from
be7107a to
39a9dae
Compare
5 participants
From the added documentation:
Re-calculate the object timers (
beresp.ttl,beresp.graceandberesp.grace) and cacheability status based on the current state ofberespas if it had been processed by core code beforevcl_backend_responsewas called.This is useful to get the default ttl calculations after modifications of relevant properties like
beresp.status,beresp.http.Date,beresp.http.Ageorberesp.http.Cache-Control.