feat: Make firmware configurable #39
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I extracted the changes as-is from #28.
I needed to set the firmware to
uefibecausebioswas not working properly when trying the build an Ubuntu 20.04 image. I had some weird issues when booting becausexenbus_probe_frontendwas timing out while waiting for devices to initialize. When usinguefi, I don't have this problem and the Packer build completes in around 15 minutes instead of 27 minutes.I'm not well-versed in Go, so let me know if something is missing such as tests or if you need more information from me.
I tested locally using:
go build -o packer-plugin-xenserver chmod +x packer-plugin-xenserver mv packer-plugin-xenserver \ /usr/local/bin/github.com/ddelnano/xenserver/packer-plugin-xenserver_v0.4.0_x5.0_darwin_amd64 sha256sum /usr/local/bin/github.com/ddelnano/xenserver/packer-plugin-xenserver_v0.4.0_x5.0_darwin_amd64 \ > /usr/local/bin/github.com/ddelnano/xenserver/packer-plugin-xenserver_v0.4.0_x5.0_darwin_amd64_SHA256SUMThen in the folder with my Packer file: