chore: RFC #2341 - 2020-04-15 - WASM Plugins Support #2341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ana Hobden <operator@hoverbear.org>
Hoverbear
changed the title
Jeffail
reviewed
Apr 21, 2020
Contributor
|
Looking good 👍 |
binarylogic
changed the title
binarylogic
changed the title
Signed-off-by: Ana Hobden <operator@hoverbear.org>
Signed-off-by: Ana Hobden <operator@hoverbear.org>
Signed-off-by: Ana Hobden <operator@hoverbear.org>
Signed-off-by: Ana Hobden <operator@hoverbear.org>
Signed-off-by: Ana Hobden <operator@hoverbear.org>
Signed-off-by: Ana Hobden <operator@hoverbear.org>
Hoverbear
changed the title
Signed-off-by: Ana Hobden <operator@hoverbear.org>
Contributor
Author
|
@lukesteensen @binarylogic this is ready for merge. :) |
lukesteensen
approved these changes
May 13, 2020
Member
lukesteensen
left a comment
lukesteensen
left a comment
There was a problem hiding this comment.
Everything here sounds reasonable. Given the amount of engineering complexity and API surface area, I expect this feature to take a long time to settle. For the time being, I think we continue to focus on completing the thinnest possible vertical slice (parsing protobufs) and gain confidence in that before expanding the API at all. We have a lot of learning to do and getting out something super minimal to start playing with will help us do that.
Contributor
Author
|
This is still waiting for one approval :) |
6 tasks
Contributor
Author
|
A little bird told me this is mergable so I'm merging it. 🎉 |
binarylogic
added
type: feature
mengesb
pushed a commit
to jacobbraaten/vector
that referenced
this pull request
Dec 9, 2020
…tordotdev#2341) * Add WASM RFC Signed-off-by: Ana Hobden <operator@hoverbear.org> * Fix lints Signed-off-by: Ana Hobden <operator@hoverbear.org> * Add title Signed-off-by: Ana Hobden <operator@hoverbear.org> * Some rewording Signed-off-by: Ana Hobden <operator@hoverbear.org> * Add lua benches Signed-off-by: Ana Hobden <operator@hoverbear.org> * Touchup RFC Signed-off-by: Ana Hobden <operator@hoverbear.org> * Add benchmarks of native and lua Signed-off-by: Ana Hobden <operator@hoverbear.org> * Review and refine RFC Signed-off-by: Ana Hobden <operator@hoverbear.org> * Move rfc Signed-off-by: Ana Hobden <operator@hoverbear.org> * Update Registration docs Signed-off-by: Ana Hobden <operator@hoverbear.org> * Remove files that weren't created. Signed-off-by: Ana Hobden <operator@hoverbear.org> Signed-off-by: Brian Menges <brian.menges@anaplan.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RFC component of #2280, related to #2006
Rendered: https://github.com/timberio/vector/blob/41d90b7df1995429d179c89a4f1c176d72a263f1/rfcs/2020-04-15-wasm-plugins.md