-
Notifications
You must be signed in to change notification settings - Fork 30k
Add gitignore note for next-env.d.ts #86809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: canary
Are you sure you want to change the base?
Add gitignore note for next-env.d.ts #86809
Conversation
Co-authored-by: joseph.chamochumbi <joseph.chamochumbi@vercel.com>
|
Cursor Agent can help with this pull request. Just |
| | [`.env.development`](/docs/app/guides/environment-variables) | Development environment variables | | ||
| | [`eslint.config.mjs`](/docs/app/api-reference/config/eslint) | Configuration file for ESLint | | ||
| | `.gitignore` | Git files and folders to ignore | | ||
| | `next-env.d.ts` | TypeScript declaration file for Next.js | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.env* files should also not be tracked
|
Hey, I just came across this PR because I was wondering if this file should be tracked by version control. I ultimately decided to track it because I saw this 4 years old comment in a GH issue by one Next.js core team member: #26533 (comment) Can you please explain me why it shouldn't be tracked? Its content almost never changes, so it seems reasonable, for me, to track it. |
|
It is a recommendation after all, but do consider that, Next.js can publish and update type signatures on that file. For example with the introduction of https://nextjs.org/docs/app/api-reference/config/next-config-js/isolatedDevBuild, or route props helpers, etc.
|
…s-claude-4.5-sonnet-thinking-645b
Slack Thread