Skip to content

fix: esbuild md loader #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
gdaybrice wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: esbuild md loader #766

gdaybrice wants to merge 1 commit into from

Conversation

@gdaybrice
Copy link

@gdaybrice gdaybrice commented Jan 11, 2026

Fixing #724

@changeset-bot
Copy link

changeset-bot bot commented Jan 11, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: 631badb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Contributor

vercel bot commented Jan 11, 2026

@gdaybrice is attempting to deploy a commit to the Vercel Labs Team on Vercel.

A member of the Team first needs to authorize it.

@gdaybrice gdaybrice force-pushed the fix/esbuild-md-loader branch from db0523d to 998213c Compare January 11, 2026 23:34
vercel[bot]
vercel bot reviewed Jan 11, 2026
View reviewed changes
@pranaygp
Copy link
Collaborator

pranaygp commented Jan 12, 2026

supporting markdown loading "by default" seems odd to me. Maybe the better option is to allow people to provide their own loaders. wdyt @ijjk ?

@gdaybrice
Copy link
Author

gdaybrice commented Jan 12, 2026

@pranaygp agree it's not ideal, would be better to support the turbopack configuration if any custom loader is setup.

@gdaybrice gdaybrice force-pushed the fix/esbuild-md-loader branch from 998213c to 5e878e5 Compare January 20, 2026 07:49
@gdaybrice
Copy link
Author

gdaybrice commented Jan 20, 2026

@pranaygp made some changes, is this a simpler approach?

vercel[bot]
vercel bot reviewed Jan 20, 2026
View reviewed changes
packages/builders/src/base-builder.ts
logLevel: 'silent',
// External packages that should not be bundled during discovery
external: this.config.externalPackages || [],
loader: this.config.esbuildLoaders,
Copy link
Contributor

@vercel vercel bot Jan 20, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent handling of optional esbuildLoaders configuration - passes undefined directly to esbuild instead of providing a sensible default

Fix on Vercel

@gdaybrice gdaybrice force-pushed the fix/esbuild-md-loader branch from 5e878e5 to 631badb Compare January 20, 2026 08:15
@socket-security
Copy link

socket-security bot commented Jan 20, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Addednpm/​raw-loader@​4.0.2991009975100

View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vercel vercel[bot] vercel[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gdaybrice @pranaygp