Fix for responsive offcanvas#859
Open
SerratedSharp wants to merge 2 commits intovikramlearning:mainfrom
Open
Conversation
…ault "offcanvas" class following BS docs for responsive offcanvas. - Includes recommended workaround for dismiss button where the default class is ommitted for this scenario per twbs/bootstrap#36962 - Added example to demos for this scenario. Tested using Demo.WebASsembly project.
- Fixes typo in commnt
Contributor
|
@SerratedSharp Thank you for the PR. I'll take care of this. |
Contributor
|
@SerratedSharp Were you able to replicate this issue here: https://demos.blazorbootstrap.com/offcanvas#sizes? If you were able to replicate the issue, please attach a screen recording. Per my analysis, this is working as expected, but it was handled slightly differently in the past. We are applying different CSS classes when different sizes are applied. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Smoke tested manually by launching Demo.WebAssembly project locally, navigating to offcanvas examples, and testing this new example as well as other examples to ensure all existing dismiss behavior still works.
I don't know if there'd be edge cases where the additional
data-bs-target="#@Id"could potentially be a breaking change. I could set it to only be rendered if EnableDefaultClass=false so it could be gracefully opted into and avoid breakig change, but conditional attributes add a bit of noise since you either need @if duplicating the line or@attributesagainst a dictionary. Let me know if you have a preference.