Use the correct triple for arm64 #126
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The triple should use aarch64 instead of arm64.
On Windows, `CMAKE_SYSTEM_PROCESSOR` can return AMD64, which fails the current check.
FtZPetruska
force-pushed
the
arm64-triple
branch
from
74c9687 to
83f245a
Compare
Author
|
Rebased on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
archcomponent of the triple used on arm64 systems isaarch64(e.g.aarch64-linux-gnu,aarch64-apple-darwin).Currently,
CMAKE_[HOST_]SYSTEM_PROCESSORreturnsarm64, which leads to the wrong triple being generated (e.g.arm64-linux-gnu).