Skip to content

Conversation

@yyx990803
Copy link

No description provided.

@netlify
Copy link

netlify bot commented Dec 26, 2025

Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit c6a5f4f
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/695ff694c6877d00085672ba
😎 Deploy Preview https://deploy-preview-9345--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sheremet-va

This comment was marked as resolved.

@sheremet-va

This comment was marked as outdated.

@yyx990803

This comment was marked as resolved.

@userquin
Copy link
Member

userquin commented Dec 26, 2025

I have some questions:

@sheremet-va
Copy link
Member

Vitest is not licensed under MIT? We don't have the license in the docs (we should add back the license to the docs home footer or change the LICENSE and footer license at README.md => #9345 (files))

I don't really see how these two are connected, the LICENSE file is the licence, not the note in the documentation. Although I am also a bit confused why the note is removed

Won't have theme applied when offline

If you can help with checking the PWA setup, please do that, you should be able to push to the branch

@userquin
Copy link
Member

userquin commented Dec 26, 2025

I don't really see how these two are connected, the LICENSE file is the licence, not the note in the documentation. Although I am also a bit confused why the note is removed

I mean if removing the license entry, we can use the voidzero like the license al readme.md with the mit license as prefix.

If you can help with checking the PWA setup, please do that, you should be able to push to the branch

Adding those files to the globIgnore will remove the files from sw precaching, if you just go offline in the network tab and refresh the page the theme is gone. We can just remove the globIgnore, running the docs in local the pwa is not enabled, I use always private browsing when checking pr preview and so I don't need to await the pwa update (maybe Evan add it to test theme changes in the pr preview).

I don't have my laptops, I will back home around mid-January.

mdong1909 and others added 2 commits January 4, 2026 12:26
Co-authored-by: Vladimir <sleuths.slews0s@icloud.com>
Co-authored-by: Hiroshi Ogawa <hi.ogawa.zz@gmail.com>
Co-authored-by: Ujjwaljain16 <jainujjwal1609@gmail.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: sheremet-va <16173870+sheremet-va@users.noreply.github.com>
Co-authored-by: hi-ogawa <4232207+hi-ogawa@users.noreply.github.com>
Co-authored-by: Ari Perkkiö <ari.perkkio@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Carlo Jeske <github@webentwickler2-0.de>
Co-authored-by: mdong1909 <mdong1909@users.noreply.github.com>
@sheremet-va
Copy link
Member

Seems like PWA plugin doesn't reset the cache properly, I always see the broken CSS when opening it after a new commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants