Fix deprecated torch_dtype usage in transformers loading

[jangel97]

While running llmcompressor, I saw the following warning:

"`torch_dtype` is deprecated! Use `dtype` instead!"

This PR replaces the deprecated torch_dtype parameter with dtype in transformers.from_pretrained() calls.

Since support for the dtype argument was introduced in transformers v4.56.1, this change also bumps the minimum supported transformers version accordingly.

Transformers ≥4.56.1 requires Python ≥3.9; however, llmcompressor already requires Python ≥3.10, so this change does not reduce Python compatibility for existing users.

The goal of this PR is to eliminate the deprecation warning and align with current transformers APIs.

Related discussion: vllm-project/vllm#26293

[github-actions]

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

[gemini-code-assist]

Summary of Changes

Hello @jangel97, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modernizes the project's interaction with the Hugging Face transformers library by adopting the non-deprecated dtype parameter for model loading. This update resolves a deprecation warning and ensures compatibility with newer transformers versions, requiring a corresponding bump in the minimum supported transformers dependency. The changes are straightforward, involving direct parameter name replacements and a version constraint update.

Highlights

• API Modernization: Replaced the deprecated torch_dtype parameter with the current dtype parameter in all transformers.from_pretrained() calls across the codebase. This change aligns the project with the latest transformers API standards.
• Dependency Update: Updated the minimum required transformers library version from 4.54.0 to 4.56.1 in setup.py. This version bump is necessary as support for the dtype argument was introduced in transformers v4.56.1.
• Warning Elimination: The primary goal of these changes is to eliminate the "torch_dtype is deprecated! Use dtype instead!" warning observed during llmcompressor execution, leading to a cleaner console output.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively addresses the deprecation warning related to torch_dtype by replacing it with dtype in transformers.from_pretrained() calls across the codebase. The setup.py file has been appropriately updated to reflect the new minimum transformers version (4.56.1), which is necessary for the dtype argument to be supported. The changes are clear, concise, and directly resolve the stated objective of aligning with current transformers APIs and eliminating the deprecation warning. No further issues were identified in the reviewed changes.

[kylesayrs]

Thanks for the contribution!

@dsikka @dhuangnm Thoughts on updating the LLM Compressor lower bound?

[dsikka]

Looks like a reasonable change.

[dhuangnm]

Thanks for implementing the fix @jangel97 !

We also have tests and examples etc using the torch_dtype, e.g.:

./tests/e2e/e2e_utils.py
./examples/quantizing_moe/qwen_example.py
./src/llmcompressor/entrypoints/utils.py
...

Can you please do a find and replace for all the files that's using torch_dtype?

[jangel97]

@dhuangnm good point, I just did!

[dhuangnm]

Thanks, LGTM!

[brian-dellabetta]

thanks for the contribution! this should be fine to merge after the release

[jangel97]

@dhuangnm @brian-dellabetta I rebased on main and had to force-push the branch.

[brian-dellabetta]

Thanks @jangel97 , the changes look good, just calling out that we need to bump transformers versions to above where the deprecation was made.

Team do we want to make this change now that the release has occurred?

[brian-dellabetta]

Hi @jangel97 , quality checks are failing, please be sure to run make style and make quality. If it's because of different versions, the ci/cd ran with:

 + ruff==0.4.10

You can see the problematic files here

[dsikka]

Hey @jangel97 do you mind fixing the quality issue so that we can land this?
You can do this with the following steps in the root directory:

pip install -e .[dev]
make style 
make quality

[jangel97]

@dsikka @brian-dellabetta, sorry I was out. I just ran those commands in my local, ran git commit and force push. Please, let me know if something else would be needed.

(venv) jmorenas-mac:llm-compressor jmorenas$ make style 
Running python styling
ruff format src tests examples setup.py; 
19 files reformatted, 335 files left unchanged
ruff check --fix src tests examples setup.py;
All checks passed!
ruff format --silent src tests examples setup.py; 

19 files reformatted.

Thanks for your help!

[brian-dellabetta]

Hi @jangel97 , the changes look good but tests are failing for an unrelated reason when interacting with the huggingface hub. I wonder if a recent PR related to the HF_TOKEN is causing community user PRs to fail with 401 gated repo errors:

• Add HF token to prevent tests from skipping #2141

Will try to get this in in the new year, thanks for the contribution!