-
-
Notifications
You must be signed in to change notification settings - Fork 11.9k
[Feat] Refactor for parallel_config in FusedMoEModularKernel
#30282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: yewentao256 <zhyanwentao@126.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a helpful comment to vllm/model_executor/layers/fused_moe/modular_kernel.py clarifying the logic for handling the parallel_config parameter in FusedMoEModularKernel. The comment explains that while explicit passing is preferred, a fallback to the current vLLM config exists for testing purposes. This improves code clarity and maintainability. The change is correct and I have no further suggestions.
parallel_config in FusedMoEModularKernelparallel_config in FusedMoEModularKernel
Signed-off-by: yewentao256 <zhyanwentao@126.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Signed-off-by: yewentao256 <zhyanwentao@126.com>
Purpose
Intend to fix #29999 (comment)
and #29999 (comment)
But after discussion with @ProExpertProg and @bnellnm , we found that require a must-pass param needs to update everything especially for tests, we decide to instead using a moe_parallel_config
This PR could also fix current issue in main