-
Notifications
You must be signed in to change notification settings - Fork 2.5k
mupdf: update to 1.27.0 #58111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mupdf: update to 1.27.0 #58111
Conversation
|
You don't have to rename the branch every time you update the PR |
|
Please ping the template maintainer when you update a package. |
|
There's a new release (1.27.0) - if you do the update, could you try w/o |
Sure. Is this because you intend to update |
Yes, because it needs to be rebuilt against a new |
|
Why are you revbumping these packages? |
d1a8905 to
61b7b2e
Compare
I misunderstood the part about revbump in the contributing guide. These commits are dropped now. |
|
Maybe also adjust the title (and checks will be enabled eventually) |
|
@ahesford dependencies need to be revbumped since mupdf is linked statically. |
|
Is that also the case for the zathura package? |
|
@ahesford only for zathura-pdf-mupdf i think? |
In that case, all of the revbumps should be restored, including @dogknowsnx please do not advise contributors to remove revbumps from PRs when you are working on independent updates. Each pull request must be self-sufficient and not introduce breakage or interdependencies between pull requests. |
Well, sorry, but I'm still learning myself.. |
To clarify, I initially applied revbumps because of the comment in the second line of the template. |
|
I don't understand why you removed depends= on mupdf-devel and added the stuff manually to the other templates? |
I thought that it'd be better to have the other packages explicitly including jbig2dec-devel as a make dependency, as the fulfilment of that build requirement is independent of mupdf itself and of its use since all third party libraries are statically linked to via The other two dependencies of mupdf-devel I removed are likely dependencies of other packages in makedepends. I didn't add them explicitly because I found that jbig2dec-devel was the only dependency that'd be missing. I can revert these changes if they're inappropriate or unnecessary. |
|
That's not true, libmupdf.a links against unresolved symbols of jbig_* etc. The former way was correct. |
ef8cfa4 to
1affd78
Compare
Testing the changes
Local build testing
Renaming the branch automatically closed my previous PR #57974 which initially updated mupdf to 1.26.11.