Skip to content

Conversation

@ldwgchen
Copy link
Contributor

@ldwgchen ldwgchen commented Dec 7, 2025

Testing the changes

  • I tested the changes in this PR: briefly

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)
  • I built this PR locally for these architectures (crossbuilds):
    • x86_64-musl
    • aarch64

Renaming the branch automatically closed my previous PR #57974 which initially updated mupdf to 1.26.11.

@ldwgchen ldwgchen changed the title Mupdf 1.26.12 mupdf: update to 1.26.12 Dec 7, 2025
@dogknowsnx
Copy link
Contributor

dogknowsnx commented Dec 7, 2025

You don't have to rename the branch every time you update the PR

@ahesford
Copy link
Member

Please ping the template maintainer when you update a package.

@cinerea0

@dogknowsnx
Copy link
Contributor

There's a new release (1.27.0) - if you do the update, could you try w/o zathura-pdf-mupdf?

@ldwgchen
Copy link
Contributor Author

ldwgchen commented Feb 2, 2026

There's a new release (1.27.0) - if you do the update, could you try w/o zathura-pdf-mupdf?

Sure. Is this because you intend to update zathura-pdf-mupdf in #57776?

@dogknowsnx
Copy link
Contributor

Sure. Is this because you intend to update zathura-pdf-mupdf in #57776?

Yes, because it needs to be rebuilt against a new girara release

@ahesford
Copy link
Member

ahesford commented Feb 2, 2026

Why are you revbumping these packages?

@ldwgchen
Copy link
Contributor Author

ldwgchen commented Feb 2, 2026

Why are you revbumping these packages?

I misunderstood the part about revbump in the contributing guide. These commits are dropped now.

@dogknowsnx
Copy link
Contributor

Maybe also adjust the title (and checks will be enabled eventually)

@ldwgchen ldwgchen changed the title mupdf: update to 1.26.12 mupdf: update to 1.27.0 Feb 3, 2026
@leahneukirchen
Copy link
Member

@ahesford dependencies need to be revbumped since mupdf is linked statically.

@ahesford
Copy link
Member

ahesford commented Feb 4, 2026

Is that also the case for the zathura package?

@leahneukirchen
Copy link
Member

@ahesford only for zathura-pdf-mupdf i think?

@ahesford
Copy link
Member

ahesford commented Feb 5, 2026

@ahesford only for zathura-pdf-mupdf i think?

In that case, all of the revbumps should be restored, including zathura-pdf-mupdf.

@dogknowsnx please do not advise contributors to remove revbumps from PRs when you are working on independent updates. Each pull request must be self-sufficient and not introduce breakage or interdependencies between pull requests.

@dogknowsnx
Copy link
Contributor

@ahesford only for zathura-pdf-mupdf i think?

In that case, all of the revbumps should be restored, including zathura-pdf-mupdf.

@dogknowsnx please do not advise contributors to remove revbumps from PRs when you are working on independent updates. Each pull request must be self-sufficient and not introduce breakage or interdependencies between pull requests.

Well, sorry, but I'm still learning myself..

@ldwgchen
Copy link
Contributor Author

ldwgchen commented Feb 7, 2026

Why are you revbumping these packages?

I misunderstood the part about revbump in the contributing guide. These commits are dropped now.

To clarify, I initially applied revbumps because of the comment in the second line of the template.

@leahneukirchen
Copy link
Member

I don't understand why you removed depends= on mupdf-devel and added the stuff manually to the other templates?

@ldwgchen
Copy link
Contributor Author

ldwgchen commented Feb 8, 2026

I don't understand why you removed depends= on mupdf-devel and added the stuff manually to the other templates?

I thought that it'd be better to have the other packages explicitly including jbig2dec-devel as a make dependency, as the fulfilment of that build requirement is independent of mupdf itself and of its use since all third party libraries are statically linked to via libmupdf-third.a.

The other two dependencies of mupdf-devel I removed are likely dependencies of other packages in makedepends. I didn't add them explicitly because I found that jbig2dec-devel was the only dependency that'd be missing.

I can revert these changes if they're inappropriate or unnecessary.

@leahneukirchen
Copy link
Member

That's not true, libmupdf.a links against unresolved symbols of jbig_* etc. The former way was correct.

@leahneukirchen leahneukirchen merged commit ea8d09f into void-linux:master Feb 9, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants