fix: Handle empty constant arrays in ScalarFnConstantRule #6067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert Kruszewski <github@robertk.io>
gatesn
reviewed
Jan 20, 2026
Contributor
gatesn
left a comment
gatesn
left a comment
There was a problem hiding this comment.
Seems like a weird place to live? Should optimizer.rs just replace length 0 arrays with Canonical::empty?
gatesn
approved these changes
Jan 20, 2026
Contributor
Author
|
I am not sure if blanket replacement is good. There's probably a different short cirtcuit you can perform depending on the rule |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #6065
Signed-off-by: Robert Kruszewski github@robertk.io