-
Notifications
You must be signed in to change notification settings - Fork 126
feat: Binary CASE WHEN expression with support for nested conditions … #6197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
…13) * feat: implement binary CASE WHEN expression with support for nested conditions
|
Sorry we just merged a break: #6081. We will be updating the PR very soon with a migration |
| bencher | ||
| .with_inputs(|| (&expr, &array)) | ||
| .bench_refs(|(expr, array)| { | ||
| let mut ctx = SESSION.create_execution_ctx(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we pass in ctx from with_inputs
joseph-isaacs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One little one otherwise looks good.
Thanks for this
|
Looks like the merge was a little off |
Adds support for the "CASE WHEN" SQL expression to the Vortex expression system, including its conversion from DataFusion, benchmarking, and pushdown logic. The main focus is on enabling CASE WHEN expressions to be parsed, converted, and benchmarked, while ensuring only supported forms are handled.
Support for CASE WHEN expressions:
case_whentovortex-array's expression system and re-exported its functions, enabling construction and evaluation of CASE WHEN and nested CASE WHEN expressions. (vortex-array/src/expr/exprs/mod.rs) [1] [2]CaseWhenexpression in theExprSessionso it can be used in expression evaluation. (vortex-array/src/expr/session.rs) [1] [2]DataFusion integration and conversion:
CaseExprto Vortex's nestedcase_whenexpressions, with validation to only support the "searched CASE" form (not "simple CASE"). (vortex-datafusion/src/convert/exprs.rs) [1] [2] [3]vortex-datafusion/src/convert/exprs.rs) [1] [2]Benchmarks and protocol updates:
vortex-array/benches/expr/case_when_bench.rs,vortex-array/Cargo.toml) [1] [2]vortex-proto/proto/expr.proto)Bench: