Skip to content

performance: Use push_unchecked when building indices for element take in fixedsizedlist take #6222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robert3005 wants to merge 2 commits into
base: develop
Choose a base branch
from

comment

4ab43a1
Select commit
Loading
Failed to load commit list.
Open

performance: Use push_unchecked when building indices for element take in fixedsizedlist take #6222

comment
4ab43a1
Select commit
Loading
Failed to load commit list.
CodSpeed HQ / CodSpeed Performance Analysis failed Feb 2, 2026 in 0s

Performance Regression: -32.37%

Summary

⚡ 20 improved benchmarks
❌ 1 regressed benchmark
✅ 1117 untouched benchmarks
⏩ 1384 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation chunked_bool_into_canonical[(1000, 10)] 43.1 µs 63.7 µs -32.37%
⚡ Simulation take_fsl_nullable_random[1024, 100] 3.1 ms 2 ms +54.43%
⚡ Simulation take_fsl_nullable_random[256, 100] 796.3 µs 525.5 µs +51.54%
⚡ Simulation take_fsl_nullable_random[1024, 1000] 32.6 ms 22.6 ms +44.58%
⚡ Simulation take_fsl_nullable_random[16, 1000] 533.6 µs 399.2 µs +33.66%
⚡ Simulation take_fsl_nullable_random[64, 1000] 1.9 ms 1.3 ms +47.87%
⚡ Simulation take_fsl_nullable_random[64, 100] 233.6 µs 165.5 µs +41.13%
⚡ Simulation take_fsl_random[16, 1000] 516.1 µs 366.5 µs +40.81%
⚡ Simulation take_fsl_nullable_random[4096, 1000] 131 ms 90.8 ms +44.32%
⚡ Simulation take_fsl_random[1024, 1000] 34.4 ms 23 ms +49.44%
⚡ Simulation take_fsl_nullable_random[16, 100] 140.7 µs 123.6 µs +13.83%
⚡ Simulation take_fsl_nullable_random[256, 1000] 7.2 ms 4.7 ms +53.19%
⚡ Simulation take_fsl_random[1024, 100] 3.1 ms 2 ms +57.14%
⚡ Simulation take_fsl_random[4096, 1000] 138.2 ms 92.7 ms +49.1%
⚡ Simulation take_fsl_nullable_random[4096, 100] 12.4 ms 8.1 ms +53.39%
⚡ Simulation take_fsl_random[256, 100] 804.6 µs 519.7 µs +54.82%
⚡ Simulation take_fsl_random[16, 100] 75 µs 59.7 µs +25.61%
⚡ Simulation take_fsl_random[4096, 100] 12.7 ms 8.2 ms +55.62%
⚡ Simulation take_fsl_random[256, 1000] 7.8 ms 4.9 ms +57.72%
⚡ Simulation take_fsl_random[64, 1000] 2 ms 1.3 ms +53.46%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Footnotes

  1. 1384 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

View more details on CodSpeed HQ