Fix inheritance sample code in CONCEPTS.md

[izumin5210]

No description provided.

[codecov]

Codecov Report

Merging #35 (26af265) into master (3008db8) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #35   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          271       271           
  Branches        48        48           
=========================================
  Hits           271       271           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3008db8...26af265. Read the comment docs.

[qnighy]

This is not an intended usage. Is there a problem with computed_model itself? If it's pb-serializer's problem, please leave it as-is and write a notice somewhere else.

[qnighy]

Although include do ... end may work as well, this is unrelated to computed_model's inheritance feature, so the example won't fit here.

[izumin5210]

This seems to be a problem on the computed model side.
Here is the code that reproduces it. If you do not use included, you will get an error.

module UserConcern
  extend ActiveSupport::Concern
  include ComputedModel::Model

  dependency raw_user: [:first_name, :last_name]
  computed def name
    [raw_user.first_name, raw_user.last_name].map(&:presence).compact.join(' ')
  end
end

# NoMethodError: undefined method `dependency' for UserConcern:Module
# from <main>:5:in `<module:UserConcern>'

[qnighy]

Thanks, reproduced! It's strange though. Kinda ActiveSupport::Concern's corner case? The following modifications work.

module UserConcern
  # extend ActiveSupport::Concern
  include ComputedModel::Model

  dependency raw_user: [:first_name, :last_name]
  computed def name
    [raw_user.first_name, raw_user.last_name].map(&:presence).compact.join(' ')
  end
end

module UserConcern
  extend ActiveSupport::Concern
  include ComputedModel::Model
  extend ComputedModel::Model::ClassMethods

  dependency raw_user: [:first_name, :last_name]
  computed def name
    [raw_user.first_name, raw_user.last_name].map(&:presence).compact.join(' ')
  end
end

[qnighy]

Anyway include do ... end is not an intended fix. Let's investigate it in #36