fix: extra runtime global bits are lost after js hook #12275
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack canceled.Built without sensitive environment variables
|
github-actions
bot
added
the
release: bug fix
CodSpeed Performance ReportMerging #12275 will not alter performanceComparing Summary
|
Contributor
Author
|
hi @LingyuCoder E2E testing passed on my machine. It seems flaky. Can you help rerun the failing job? |
nilptr
force-pushed
the
nilptr/fix/additional-runtime-global-bits-lost-after-js-hook
branch
from
b546e87 to
f92441b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I'm building a Rspack Custom Binding that uses some untaken
RuntimeGlobalsbits.I noticed these extra bits are lost after the serialization&deserialization for JS
compilation.hooks.additionalTreeRuntimeRequirements.Related links
Checklist