-
Notifications
You must be signed in to change notification settings - Fork 165
Fix samples #960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
erseco
wants to merge
25
commits into
webodf:master
Choose a base branch
from
erseco:fix-samples
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix samples #960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a GitHub Actions workflow to automate the build and deployment of the `webodf.js` library and a viewer demo to GitHub Pages. The workflow performs the following steps: - Sets up an Ubuntu environment with required dependencies (CMake, Java, Qt). - Builds the `webodf.js` library using the provided build instructions. - Deploys the compiled library and a new `viewer/index.html` demo page to the `gh-pages` branch. A new `viewer/index.html` file has been added to serve as a simple ODT file viewer, demonstrating the use of the deployed `webodf.js` library.
feat: Add GitHub Actions workflow for GitHub Pages deployment
Bumps the npm_and_yarn group with 1 update in the /programs/editor/dojo-deps/src/app directory: [dojox](https://github.com/dojo/dojox). Updates `dojox` from 1.8.0 to 1.14.6 - [Commits](dojo/dojox@1.8.0...1.14.6) --- updated-dependencies: - dependency-name: dojox dependency-version: 1.14.6 dependency-type: direct:production dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps the npm_and_yarn group with 1 update in the /programs/editor/dojo-deps/src/app directory: [dojo](https://github.com/dojo/dojo). Updates `dojo` from 1.8.0 to 1.16.5 - [Commits](dojo/dojo@1.8.0...1.16.5) --- updated-dependencies: - dependency-name: dojo dependency-version: 1.16.5 dependency-type: direct:production dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com>
…itor/dojo-deps/src/app/npm_and_yarn-985663593e Bump dojo from 1.8.0 to 1.16.5 in /programs/editor/dojo-deps/src/app in the npm_and_yarn group across 1 directory
…itor/dojo-deps/src/app/npm_and_yarn-c725fcb72d Bump dojox from 1.8.0 to 1.14.6 in /programs/editor/dojo-deps/src/app in the npm_and_yarn group across 1 directory
The GitHub Actions workflow was failing during the cmake configuration because it could not determine the project version. The build script relies on `git describe --tags`, which requires the full git history. This change modifies the `actions/checkout` step to perform a full clone by setting `fetch-depth: 0`, ensuring that the necessary git tags and history are available during the build process.
Bumps the npm_and_yarn group with 1 update in the /programs/editor/dojo-deps/src/app directory: [dijit](https://github.com/dojo/dijit). Updates `dijit` from 1.8.0 to 1.13.8 - [Commits](dojo/dijit@1.8.0...1.13.8) --- updated-dependencies: - dependency-name: dijit dependency-version: 1.13.8 dependency-type: direct:production dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com>
Fix: CI build failure due to missing git history
…itor/dojo-deps/src/app/npm_and_yarn-c83ff29f31 Bump dijit from 1.8.0 to 1.13.8 in /programs/editor/dojo-deps/src/app in the npm_and_yarn group across 1 directory
This change introduces a new CI workflow that runs on pull requests to the master branch. The workflow builds the project to ensure that changes do not break the build. The deployment steps are now conditional and will only run on pushes to the master branch. Additionally, this change adds a Dependabot configuration file to automatically check for updates to GitHub Actions.
feat: Configure CI and Dependabot
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 5. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2...v5) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [peaceiris/actions-gh-pages](https://github.com/peaceiris/actions-gh-pages) from 3 to 4. - [Release notes](https://github.com/peaceiris/actions-gh-pages/releases) - [Changelog](https://github.com/peaceiris/actions-gh-pages/blob/main/CHANGELOG.md) - [Commits](peaceiris/actions-gh-pages@v3...v4) --- updated-dependencies: - dependency-name: peaceiris/actions-gh-pages dependency-version: '4' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…heckout-5 Bump actions/checkout from 2 to 5
…/actions-gh-pages-4 Bump peaceiris/actions-gh-pages from 3 to 4
This change addresses a broken build and implements caching to speed up the CI process. The build was failing due to two issues: - An outdated Dojo Toolkit URL in `CMakeLists.txt`. - A bug in `webodf/tools/updateJS.js` where `fs.writeFile` was called without a callback. Both issues have been resolved. Caching has been added to the CI workflow in `.github/workflows/ci.yml`. The `build` directory is now cached, which includes both downloaded dependencies and build artifacts. The build step is skipped if a cache hit occurs, which will significantly reduce build times on subsequent runs.
Fix build and add caching to CI workflow
This change modifies the GitHub Actions workflow to implement a dynamic versioning scheme. - For pull requests and pushes to the `master` branch, the version is set to `0.0.0-build<commithash>`. This avoids caching issues and provides a unique version for each build. - For tagged releases (e.g., `v1.2.3`), the version is determined by the Git tag, allowing for proper release versioning. The workflow now triggers on tag pushes, and the build step is always executed to ensure artifacts are generated correctly.
Implement Dynamic Build Versioning in CI
… 5 template. The new layout has a sidebar for the file list and a main container for the viewer. I have added the JavaScript code to load the sample ODT files when a user clicks on them. Users can now drag and drop their own ODT files to be viewed. I will now proceed to the pre-commit steps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.