refactor: migrate to jest assertion #698
Open
+144
−270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
force-pushed
the
remove-unnecessary-deps
branch
from
3b36cb0 to
cc15a42
Compare
Member
Author
|
@valscion ready for review |
valscion
approved these changes
Jan 24, 2026
| // On node.js v16 and lower, the calculated gzip is one byte larger. Nice. | ||
| gzipSize: | ||
| parseInt(process.versions.node.split(".")[0]) <= 16 ? 360 : 358, | ||
| parsedSize: 1349, |
Member
There was a problem hiding this comment.
Huh. Why did the parsedSize change here and in some other assertions here as well?
Member
Author
There was a problem hiding this comment.
Looks like chai has bugs here, as you can see we don't change something here except migration to jest assertion
| await expectValidReport({ parsedSize: 1317, gzipSize: 341 }); | ||
| }); | ||
|
|
||
| it.only("should support brotli", async function () { |
Member
There was a problem hiding this comment.
Was this the reason? We had accidentally left a it.only here? 😬
Member
Author
There was a problem hiding this comment.
Yes, it is a fix
Member
Author
There was a problem hiding this comment.
We also have skip tests in some places, I will fix them in other PRs
UlisesGascon
approved these changes
Jan 24, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use jest assertion
What kind of change does this PR introduce?
refactor test
Did you add tests for your changes?
Existing
Does this PR introduce a breaking change?
No
If relevant, what needs to be documented once your changes are merged or what have you already documented?
Nothing