fix: replace notification dismiss div with semantic button (#7737) #7747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Kritank07 is attempting to deploy a commit to the OpenJS Foundation Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
|
This doesnt look right. Expected
Recieved
|
Contributor
Author
|
I have updated the dismiss element to a semantic to fix the Firefox issue. I also added a CSS reset (background: none, border: none) to ensure the visual appearance matches the original design exactly. Please check the latest commit." |
evenstensberg
approved these changes
Jan 18, 2026
Member
|
I've already approved it 😄 |
Contributor
Author
|
Thank you for the approval! I've confirmed that all checks have passed and the unrelated changes have been separated into their own branch. Is there anything else needed before this can be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The notification alerting users about the documentation version cannot be dismissed in certain browsers, specifically Firefox. This is caused by using a non-semantic
Solution
Updated the dismissal element in the NotificationBar component from a
Maintained existing CSS classes and the onClick handler to ensure visual and functional consistency.
Ensured the CloseIcon remains correctly nested within the new button element for proper click targeting.