Don't remove excluded-on-redirect URLs from seen list #936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng them from the seen list avoids requeuing URLs that are excluded on redirect
…s are not written for excluded-on-redirect page
…ere should also be no urn:pageinfo record added for excluded pages
tw4l
approved these changes
Dec 8, 2025
Member
tw4l
left a comment
tw4l
left a comment
There was a problem hiding this comment.
Nice change, and thanks for the good tests! Also tried it out locally and confirmed it's behaving as expected.
Member
|
Might want to create an issue to link this to or add this PR to our sprint board just for tracking purposes. |
…s + excluded pages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #937