feat: cors setup using route options, removed hapi-cors plugin#73
Open
christin-wednesday wants to merge 1 commit intomainfrom
Open
feat: cors setup using route options, removed hapi-cors plugin#73christin-wednesday wants to merge 1 commit intomainfrom
christin-wednesday wants to merge 1 commit intomainfrom
Conversation
Signed-off-by: Chris <christinittyofc@gmail.com>
Coverage report❌ The test suite failed. Please, check the console output for more details. Report generated by 🧪jest coverage report action from a13042b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket Link
Closes #69
Related Links
Description
Use the withCors function to create a route that has cors headers enabled.
Instead of using the hapi-cors plugin, use
route.options.corsSupports config overriding.
Default cors origins can be defined in the withCors function, on the basis of env.
Since it is a common use case to conditionally do something on the basis of ENVIRONMENT_NAME, added a function that guards / gate keeps the value of this environment variable.
Also this seemed like a good use case for getters :)
Steps to Reproduce / Test
Checklist
yarn testpasses