Skip to content

Render v8 account status #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
whichnode merged 2 commits into from
May 12, 2025
Merged

Render v8 account status #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2081b2
Add uninitialized account note
whichnode May 12, 2025
a9578c1
Fix unlocked balance displayed in validators table
whichnode May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion api/src/ol/validators/validators.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,9 @@ export class ValidatorsService {
const balance = await this.olService.getAccountBalance(validator.address);
const currentBid = await this.olService.getCurrentBid(validator.address);
const slowWallet = await this.olService.getSlowWallet(validator.address);
const unlocked = Number(slowWallet?.unlocked);
// If we hit an uninitialized V7 slow wallet we need to override the unlocked balance as zero
const initialized = await this.olService.getInitialized(validator.address);
const unlocked = initialized ? Number(slowWallet?.unlocked) : Number(0);
const addr = validator.address.toString('hex').toLocaleUpperCase();
if (!handles.get(addr)) {
this.logger.debug(`handles miss for address ${addr}`)
Expand Down
9 changes: 7 additions & 2 deletions web-app/src/modules/core/routes/Account/Account.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,13 @@ const Account: FC<Props> = ({ accountAddress }) => {
}
>

// Correct balance display for un-migrated V7 slow wallets:
// If it's a slow wallet and not initialized then display unlocked as zero and balance as correct, add a note that account is not initialized
{
// Correct balance display for un-migrated V7 slow wallets:
// If it's a slow wallet and not initialized then display unlocked as zero and balance as correct,
// add a note that account is not initialized
account.initialized && ( <div>Note: this account has not been initialized</div> )
}

<div className="grid grid-cols-12 gap-4">
{data.account.balance !== null && (
<div className="col-span-12 md:col-span-3 mt-5 gap-5">
Expand Down