Skip to content

Conversation

@MohamadJaara
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

some use cases are exposing either class instead of results

Solutions

refactor em

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina enabled auto-merge January 12, 2026 14:54
@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Jan 12, 2026

Codecov Report

❌ Patch coverage is 12.06897% with 51 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.71%. Comparing base (7876789) to head (59c1df2).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...d/ui/e2eiEnrollment/GetE2EICertificateViewModel.kt 0.00% 10 Missing and 3 partials ⚠️
...wire/android/ui/debug/DebugDataOptionsViewModel.kt 0.00% 11 Missing and 1 partial ⚠️
...roid/ui/settings/devices/DeviceDetailsViewModel.kt 43.75% 7 Missing and 2 partials ⚠️
...droid/ui/e2eiEnrollment/E2EIEnrollmentViewModel.kt 0.00% 6 Missing and 1 partial ⚠️
...d/ui/home/sync/FeatureFlagNotificationViewModel.kt 0.00% 5 Missing and 1 partial ⚠️
...erprofile/other/OtherUserProfileScreenViewModel.kt 0.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4515      +/-   ##
===========================================
- Coverage    48.98%   48.71%   -0.28%     
===========================================
  Files          565      571       +6     
  Lines        19561    19672     +111     
  Branches      3258     3289      +31     
===========================================
+ Hits          9582     9583       +1     
- Misses        8980     9082     +102     
- Partials       999     1007       +8     
Files with missing lines Coverage Δ
...erprofile/other/OtherUserProfileScreenViewModel.kt 66.93% <0.00%> (-1.66%) ⬇️
...d/ui/home/sync/FeatureFlagNotificationViewModel.kt 57.97% <0.00%> (+2.41%) ⬆️
...droid/ui/e2eiEnrollment/E2EIEnrollmentViewModel.kt 0.00% <0.00%> (ø)
...roid/ui/settings/devices/DeviceDetailsViewModel.kt 71.09% <43.75%> (+2.39%) ⬆️
...wire/android/ui/debug/DebugDataOptionsViewModel.kt 48.96% <0.00%> (-0.35%) ⬇️
...d/ui/e2eiEnrollment/GetE2EICertificateViewModel.kt 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7876789...59c1df2. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yamilmedina yamilmedina added this pull request to the merge queue Jan 12, 2026
Merged via the queue into develop with commit 892ff2a Jan 12, 2026
13 of 15 checks passed
@yamilmedina yamilmedina deleted the mo/refactor/remove-either-part1 branch January 12, 2026 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants