Skip to content

Conversation

@yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Jan 9, 2026

TaskWPB-22556 [Kalium] Create common contracts for Use Cases - Return types


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Adapt changes for


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@codecov
Copy link

codecov bot commented Jan 12, 2026

Codecov Report

❌ Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.71%. Comparing base (892ff2a) to head (62c9d72).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...ire/android/util/lifecycle/SyncLifecycleManager.kt 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4517      +/-   ##
===========================================
- Coverage    48.71%   48.71%   -0.01%     
===========================================
  Files          571      571              
  Lines        19672    19673       +1     
  Branches      3289     3293       +4     
===========================================
  Hits          9583     9583              
  Misses        9082     9082              
- Partials      1007     1008       +1     
Files with missing lines Coverage Δ
...wire/android/ui/debug/DebugDataOptionsViewModel.kt 48.96% <100.00%> (ø)
...tions/details/GroupConversationDetailsViewModel.kt 86.77% <100.00%> (ø)
...oid/ui/home/settings/account/MyAccountViewModel.kt 89.09% <100.00%> (ø)
...id/ui/userprofile/self/SelfUserProfileViewModel.kt 56.52% <100.00%> (ø)
...ire/android/util/lifecycle/SyncLifecycleManager.kt 88.23% <60.00%> (-2.68%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 892ff2a...62c9d72. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yamilmedina yamilmedina enabled auto-merge January 12, 2026 17:24
@sonarqubecloud
Copy link

@yamilmedina yamilmedina added this pull request to the merge queue Jan 12, 2026
Merged via the queue into develop with commit aca610c Jan 12, 2026
14 of 15 checks passed
@yamilmedina yamilmedina deleted the yamil/refactor/replace-either-results branch January 12, 2026 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants