feat: Use AS-SETs correctly and hint irrd with source for performance #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Todo:
|
johannwagner
force-pushed
the
feat/use-as-sets-correctly
branch
from
2e821c5 to
bf97281
Compare
Contributor
Author
|
Source filtering does apply, so I removed it. |
unfokus
reviewed
Dec 12, 2025
Collaborator
unfokus
left a comment
unfokus
left a comment
There was a problem hiding this comment.
- Checked with prod repos, no unexpected diff in output. Perfect.
- Currently the fallback is to not allow anything when resolution fails. Consider falling back to query filter for just the ASN instead?
johannwagner
force-pushed
the
feat/use-as-sets-correctly
branch
from
9c0c5a1 to
70925d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will probably change the existing filters to allow more stuff, therefore we should attend the rollout.