Add support for wolfProvider RD unit test #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
night1rider
requested changes
Dec 22, 2025
Contributor
night1rider
left a comment
night1rider
left a comment
There was a problem hiding this comment.
One thing to address
Contributor
There was a problem hiding this comment.
Should this be also added to the fips-image-minimal demo?
Contributor
Author
There was a problem hiding this comment.
Well I think it can be but does it need to be replace default conditional because it only needs to be included when we build with wolfprovider replace default
Contributor
There was a problem hiding this comment.
iirc the fip-image-minimal is setup to use replace default since this is what we recommend for fips. If it does not we should update it to use replace default then.
Contributor
Author
There was a problem hiding this comment.
Okay in that case it makes sense i will add it
Contributor
Author
There was a problem hiding this comment.
Okay should be good now
night1rider
approved these changes
Dec 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs wolfProvider #342
wolfprovider-image-minimalandwolfprovider-replace-default-image-minimal