-
Notifications
You must be signed in to change notification settings - Fork 135
Remove compile-time dependencies from key tools #521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
bf4c801
Test: adding action to build keytools on windows.
dgarske 6c8aafe
Remove keytools dependency on IMAGE_HEADER_SIZE.
danielinux 93866f7
Use minimum 512B of header with delta updates
danielinux bc5e2ce
Makefile passes IMAGE_HEADER_SIZE to sign tool.
danielinux 97fb3b6
Test: add IMAGE_HEADER_SIZE to sign command
danielinux 75efbd9
Removed all compile-time dependency from keytools
danielinux 4007d14
Added dep to target.h on tpmtools
danielinux 10cdc54
Add env variable to unit test
danielinux b6d3d4a
Renode test: add V=1
danielinux a31ddfc
Fixed include order
danielinux d393577
Fix header size in hybrid mode
danielinux b0e3000
Added libwolfboot to nrf53 app build
danielinux 137a97f
Correct include order in nrf53 test app
danielinux 05d0e92
Removed forced inflation of header size in `sign`
danielinux b2bf298
Shorten tests by not re-building keytools
danielinux 04d2ecd
Remove dependency from PQC parameters. Speed up tests.
danielinux 7132a13
Complete generic sign
danielinux d5e402e
Removing compile-time parameters from keygen
danielinux 5ab6616
keygen: removed compile-time parameters (lms, xmss)
danielinux 51eff3e
Adjusted size for ML_DSA build
danielinux c3fe505
Fix check on ML_DSA pubkey size at runtime
danielinux eddf0bd
Progress getting the Windows tools to build.
dgarske 4ac4de5
Fix ML-DSA level comment.
dgarske 8cdefaa
Fix to remove ext_XMS artifact from keytools Makefile. Caused mingw r…
dgarske 29794f2
Update wolfssl submodule to latest master that includes https://githu…
dgarske 35b98e7
Fix the Windows keytools artifact upload.
dgarske 4991eab
Peer review fixes. Default to ML-DSA level 2.
dgarske 6bed80f
ML-DSA default is level 2. The keytools must be able to support all M…
dgarske fae36f2
Reserve enough size for the ML-DSA public key in gen.
dgarske File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| name: Build Windows Keytools executables | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - master | ||
| pull_request: | ||
| branches: [ '*' ] | ||
|
|
||
| jobs: | ||
| build-windows: | ||
| runs-on: windows-latest | ||
|
|
||
| steps: | ||
| # Step 1: Checkout the repository | ||
| - name: Checkout Code | ||
| uses: actions/checkout@v3 | ||
| with: | ||
| submodules: true | ||
|
|
||
| # Step 2: Setup MSBuild | ||
| - name: Setup MSBuild | ||
| uses: microsoft/setup-msbuild@v1 | ||
|
|
||
| # Step 3: Build the solution | ||
| - name: Build Solution | ||
| shell: cmd | ||
| run: | | ||
| echo #define WOLFBOOT_SECTOR_SIZE 1024 > include\target.h | ||
| MSBuild.exe tools\keytools\wolfBootKeyTools.sln /m /p:Configuration=Release /p:Platform="x64" | ||
|
|
||
| # Step 4: Upload executables as artifacts | ||
| - name: Upload EXE Artifacts | ||
| uses: actions/upload-artifact@v3 | ||
| with: | ||
| name: windows-keytools | ||
| path: | | ||
| tools\keytools\x64\Release\*.exe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.