wolfHSM refactor: remove printf, new debug macros #207
Conversation
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 32 out of 32 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 32 out of 32 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 32 out of 32 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 32 out of 32 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 44 out of 44 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 44 out of 44 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bigbrett
left a comment
bigbrett
left a comment
There was a problem hiding this comment.
@jackctj117 A few things:
- the
DEBUGvariable for each of the makefiles should now turn onWOLFHSM_CFG_DEBUG - Add
DEBUG_VERBOSEoption to the makefiles turning onWOLFHSM_CFG_DEBUG_VERBOSE - Add a step to each of the
built-and-XXX.ymlGH actions that builds and runs withDEBUG=1andDEBUG_VERBOSE=1. Ensure it builds successfully and inspect the output manually to make sure it is behaving properly
|
@jackctj117 28 commits is way too many. Please squash. |
jackctj117
force-pushed
the
HSM_debug
branch
from
d06cccd to
1ef8bde
Compare
- Remove unnecessary DEBUG flag passing from examples/Makefile (Comment 51) - Fix 80 char line limit in wolfhsm/wh_settings.h (Comment 52) - Remove DEBUG_CRYPTOCB/DEBUG_WOLFSSL macro dependencies (Comment 53) - Rename hexdump macros to WH_DEBUG_VERBOSE_HEXDUMP (Comment 54) - Simplify WH_TEST_PRINT macro definition (Comment 55) All changes verified with local tests (ASAN=1 TESTWOLFCRYPT=1) Co-Authored-By: jack@wolfssl.com <jack@wolfssl.com>
Refactor:
Instead of relying on wolfCrypts debug macros this PR creates wolfHSM debug macros
Replace all printf statements with new print wrappers that internally uses new WOLFHSM_CFG_PRINTF