-
Notifications
You must be signed in to change notification settings - Fork 28
Add new option to enable unit testing for replace default mode #331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new option to enable unit testing for replace default mode #331
Conversation
…tly initializing the openssl default provider
|
Can we add the new mode to a CI workflow? Maybe |
|
Do we have customers wanting to do this? |
Well since I came up with replace-default, every single prospective customer has wanted the replace default option. Without this PR, we have no way to unit test wolfProvider against an openssl built with replace default. We are still in early stages with many of them, but they are already starting to ask about testing/verification. I thought this was a decent way to keep our original testing strategy against the openssl that most closely resembles what they will run in production. |
|
Document this then in the README.md then. |
|
I dont think we should be deleting binaries after test. They might want to retest, or the binaries may need to be put somewhere else or modified before ready to run for them. We have clear prints, I think that is sufficient rather than start deleting artifacts for them. |
Add new option to enable unit testing for replace default mode, directly initializing the openssl default provider