Skip to content

Conversation

@ColtonWilley
Copy link
Contributor

Add new option to enable unit testing for replace default mode, directly initializing the openssl default provider

…tly initializing the openssl default provider
@padelsbach
Copy link
Contributor

Can we add the new mode to a CI workflow? Maybe simple.yml?

@SparkiDev
Copy link
Contributor

Do we have customers wanting to do this?

@ColtonWilley
Copy link
Contributor Author

Do we have customers wanting to do this?

Well since I came up with replace-default, every single prospective customer has wanted the replace default option. Without this PR, we have no way to unit test wolfProvider against an openssl built with replace default. We are still in early stages with many of them, but they are already starting to ask about testing/verification. I thought this was a decent way to keep our original testing strategy against the openssl that most closely resembles what they will run in production.

@SparkiDev
Copy link
Contributor

Document this then in the README.md then.
Add examples to show customers how to do this.

@ColtonWilley
Copy link
Contributor Author

I dont think we should be deleting binaries after test. They might want to retest, or the binaries may need to be put somewhere else or modified before ready to run for them. We have clear prints, I think that is sufficient rather than start deleting artifacts for them.

@padelsbach padelsbach merged commit e582de1 into wolfSSL:master Dec 8, 2025
370 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants