Restrict DH keygen to 2048 bits and above for FIPS builds #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ColtonWilley
requested review from
SparkiDev,
kaleb-himes and
padelsbach
and removed request for
SparkiDev
padelsbach
reviewed
Dec 12, 2025
Contributor
|
Looks good. There are some spurious looking test failures, so I kicked off a re-run of those. Curl failure looks like we might need an update there. |
padelsbach
approved these changes
Dec 16, 2025
…_enforce_dh_keygen_min_bits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing code allowed 1024 bit DH keygen even with FIPS, disallow this behavior.