Skip to content

Conversation

@gojimmypi
Copy link
Contributor

Description

Introduces a new wolfSSL Espressif CMake Library location: IDE/Espressif/ESP-IDF/cmake.

This directory contains common functions used in various examples and components.

Instead of duplicating and maintaining functions in various examples and components, this common library can be used.

Although it can be used as-is, the intent is to include it in the published wolfSSL Managed Component and include it from there when possible.

Inspiration came from my most recent publish of the Staging Component for wolfMQTT, in particular the examples. Note there are more examples for the wolfssl Managed Component and examples for the wolfssh Managed Component - all of which need to check for duplicate components.

The initial file contains just one commonly needed function to check for duplicate component directories:

CHECK_DUPLICATE_LIBRARIES

Searches for duplicate directories containing duplicate component libraries.

Parameters:

  • RESULT_VAR (output variable)
  • KEYWORD (e.g. "wolfssl", "wolfmqtt", etc)

Fixes zd# n/a

Testing

Tested only when directly implemented in other CMakeFiles.txt. This include capability has otherwise NOT yet been implemented in any shared manner, pending review and acceptance of this PR.

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@gojimmypi
Copy link
Contributor Author

Jenkins retest this please.

To retry unrelated "java.io.StreamCorruptedException: invalid stream header: 636F7272"

Copy link
Contributor

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these files need added to the include.am to be part of make dist? Why add this without anything using it yet? There is no way to test or validate. Would prefer it part of a PR that actually uses it

@gojimmypi
Copy link
Contributor Author

I was not planning to use it as-is in the reference directory. My intention was to copy it during Managed Component publishing.

Converting to draft while I give it some more thought.

@gojimmypi gojimmypi marked this pull request as draft March 7, 2025 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants