Skip to content

Conversation

@miyazakh
Copy link
Contributor

@miyazakh miyazakh commented Dec 26, 2025

Description

Qt nightly Jenkins tests started failing after PR9522 was merged. OpenSSL performs date validation even when there are other verification issues. This PR reverts the removed logic and now uses X509StoreVerifyCertDate().

Testing

Add unit test
Run qt unit test

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@miyazakh miyazakh self-assigned this Dec 26, 2025
@devin-ai-integration
Copy link
Contributor

🛟 Devin Lifeguard found 3 likely issues in this PR

  • no-memory-leaks snippet: Call X509_free(ca); immediately before setting ca = NULL; (and remove the second X509_free(cert)), in both newly-added blocks of test_wolfSSL_X509_STORE_check_time.
  • check-all-return-codes snippet: Capture and assert the return value from X509_VERIFY_PARAM_set_flags(), e.g. ExpectIntEQ(X509_VERIFY_PARAM_set_flags(store->param, WOLFSSL_NO_CHECK_TIME), 1);.
  • pointer-null-check snippet: Change the condition to if (ctx->store != NULL && ctx->store->verify_cb != NULL) before using ctx->store->verify_cb.

@miyazakh
please take a look at the above issues which Devin flagged. Devin will not fix these issues automatically.

@miyazakh
Copy link
Contributor Author

retest this please

Found unhandled org.jenkinsci.plugins.workflow.support.steps.AgentOfflineException exception:

@miyazakh miyazakh removed their assignment Dec 26, 2025
@miyazakh
Copy link
Contributor Author

miyazakh commented Jan 6, 2026

retest this please

Found unhandled org.jenkinsci.plugins.workflow.support.steps.AgentOfflineException exception:

@miyazakh miyazakh assigned julek-wolfssl and unassigned miyazakh Jan 6, 2026
@miyazakh
Copy link
Contributor Author

miyazakh commented Jan 7, 2026

retest this please

Found unhandled java.lang.NullPointerException exception:
Cannot invoke method getEnvironment() on null object

Copy link
Member

@julek-wolfssl julek-wolfssl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also one comment from previous review is not fixed.

fix indentation
@miyazakh
Copy link
Contributor Author

miyazakh commented Jan 7, 2026

retest this please

@miyazakh miyazakh assigned julek-wolfssl and unassigned miyazakh Jan 7, 2026
@julek-wolfssl julek-wolfssl removed their assignment Jan 7, 2026
@miyazakh
Copy link
Contributor Author

miyazakh commented Jan 8, 2026

retest this please

Found unhandled java.io.InterruptedIOException exception:

@dgarske dgarske merged commit d25f98f into wolfSSL:master Jan 8, 2026
393 of 395 checks passed
@miyazakh miyazakh deleted the fix_qtfail branch January 9, 2026 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants