Fix switch case handling in TLSX_IsGroupSupported function#9777
Merged
dgarske merged 1 commit intowolfSSL:masterfrom Feb 16, 2026
Merged
Conversation
|
Can one of the admins verify this patch? |
Contributor
|
Okay to test. Contributor agreement on file. |
Frauschi
approved these changes
Feb 16, 2026
Contributor
Frauschi
left a comment
There was a problem hiding this comment.
Looks good, thanks for the fix!
dgarske
approved these changes
Feb 16, 2026
Contributor
|
@Pushyanth-Infineon thank you for this fix. Our CI should have caught this, so we are looking into how to better test this edge case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix missing
breakstatements in ML-KEM group switch cases causingTLSX_IsGroupSupported()function to return failure even if the group is supported.Description
In
src/tls.c, the functionTLSX_IsGroupSupportedwill return 0 (failure) when:namedGroupis WOLFSSL_ML_KEM_512 or WOLFSSL_ML_KEM_768 or their hybrid variants.In this case the execution will not reach
breaksince it is present inside!WOLFSSL_NO_ML_KEM_1024code block.To fix this, add
break;at the end of!WOLFSSL_NO_ML_KEM_512and!WOLFSSL_NO_ML_KEM_768blocks to handle the flow individually.Testing
Checklist