Fix issues found during src/ code review#9779
Merged
dgarske merged 1 commit intowolfSSL:masterfrom Feb 16, 2026
Merged
Conversation
- ECH: add bounds check on hpkePubkeyLen against HPKE_Npk_MAX to prevent heap buffer overflow from untrusted ECH config data - Sniffer: fix reassembly memory limit check typo, MaxRecoveryMemory -1 should be MaxRecoveryMemory != -1 - Sniffer: add bounds check in IPv6 extension header parsing loop to prevent OOB read when next_header never matches TCP or NO_NEXT_HEADER - Sniffer: validate tlsFragOffset + rhSize against tlsFragSize before XMEMCPY in both TLS handshake fragment reassembly paths - Internal: use WC_SAFE_SUM_WORD32 in GrowAnOutputBuffer to prevent integer overflow on allocation size, matching existing pattern in GrowOutputBuffer
dgarske
approved these changes
Feb 16, 2026
dgarske
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ECH: add bounds check on hpkePubkeyLen against HPKE_Npk_MAX to prevent heap buffer overflow from untrusted ECH config data
Sniffer: fix reassembly memory limit check typo, MaxRecoveryMemory -1 should be MaxRecoveryMemory != -1
Sniffer: add bounds check in IPv6 extension header parsing loop to prevent OOB read when next_header never matches TCP or NO_NEXT_HEADER
Sniffer: validate tlsFragOffset + rhSize against tlsFragSize before XMEMCPY in both TLS handshake fragment reassembly paths
Internal: use WC_SAFE_SUM_WORD32 in GrowAnOutputBuffer to prevent integer overflow on allocation size, matching existing pattern in GrowOutputBuffer