fix: Ensure EditorAssetBundleProvider always replies to JavaScript #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid indefinite hangs for the JavaScript runtime.
dcalhoun
commented
Jan 26, 2026
| replyHandler(reply, nil) | ||
| } catch { | ||
| Logger.assetLibrary.error("📚 Failed to fetch asset manifest: \(error.localizedDescription)") | ||
| replyHandler(nil, error.localizedDescription) |
Member
Author
There was a problem hiding this comment.
This absence did not create an observed issue, but it seems like we should invoke replyHandler here.
Member
Author
|
Noticed a Sentry report. It could be unrelated, but this might fix it: JETPACK-IOS-1JEE |
jkmassel
approved these changes
Jan 29, 2026
Contributor
jkmassel
left a comment
jkmassel
left a comment
There was a problem hiding this comment.
Oof nice fix, thanks for dealing with it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Ensures that
EditorAssetBundleProvideralways calls thereplyHandlerwhen handling JavaScript message requests, even when an error occurs.Why?
When
getEditorRepresentation()throws an error, thereplyHandlerwas not being called. This would leave JavaScript waiting indefinitely for a response that never comes, potentially causing the editor to hang or behave unexpectedly.How?
Added the missing
replyHandler(nil, error.localizedDescription)call in the catch block ofuserContentController(_:didReceive:replyHandler:).Testing Instructions
No specific reproduction steps are known. This fix was identified during code review.
Accessibility Testing Instructions
N/A - This is an internal fix with no UI changes.
Screenshots or screencast
N/A