fix: Editor preloading survives blocked asset downloads #305
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Makes the editor resilient to individual asset download failures during preloading, preventing the editor from failing to load when content blockers (like AdGuard) block analytics scripts.
Why?
Fix CMM-1179.
When AdGuard blocks
stats.wp.com/w.js, theEditorAssetLibrary.buildBundle()method was failing entirely because it usedwithThrowingTaskGroup- any single asset failure would cause the entire bundle download to fail, resulting in an "Editor Error" screen with "bad URL" message.How?
Production code (
EditorAssetLibrary.swift)buildBundle()fromwithThrowingTaskGrouptowithTaskGroupfetchAsset()to returnVoidinstead ofURL(return value was unused)Test code (
EditorAssetLibraryTests.swift)EditorAssetLibraryMockHTTPClientby:urlResponseHandlerthrowable:((URL) throws -> Data)shouldThrowErroranddownloadResponsepropertiesperform()anddownload()methodsTesting Instructions
stats.wp.comin some manner—e.g., AdGuard, Proxyman.Automated Testing
make test-swift-package- all tests pass including new testbuildBundle continues when individual asset downloads fail