fix: Address Swift compiler warnings #306
Draft
+1
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `existingBundle(forManifestChecksum:)` method doesn't throw, so the `try` keyword was unnecessary. The `await` is still required because `EditorAssetLibrary` is an actor. Fixes warning: no calls to throwing functions occur within 'try' expression
This property was deprecated in iOS 11.0 and is ignored by the system. Selection granularity is always `.character` by default. Fixes warning: 'selectionGranularity' was deprecated in iOS 11.0: This property is ignored; selection granularity is always `character`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes two Swift compiler warnings that appear when building the Swift package.
Why?
These warnings add noise to the build output and indicate code that could be cleaned up:
trykeyword on a non-throwing actor methodHow?
tryfrom theexistingBundle(forManifestChecksum:)call in tests (the method doesn't throw, butawaitis still required since it's an actor)selectionGranularityproperty assignment, which has been ignored since iOS 11.0Testing Instructions
make test-swift-packageEditorAssetLibraryTests.swiftorEditorViewController.swiftAccessibility Testing Instructions
N/A - no UI changes.
Screenshots or screencast
N/A