Merge final release/20.9

[AliSoftware]

• changelog/*.txt files updated with latest translations
• values*/strings.xml updated with latest translations
• Version bumped in version.properties
• WPAndroid submitted to Google for review
• JPAndroid submitted to Google for review

[ParaskP7]

👋 @AliSoftware !

If I am not mistaken, the new fastlane/metadata/android/en-US/changelogs/1281.txt file is missing, can you confirm that? 🤔

[wpmobilebot]

📲 You can test these changes on WordPress by downloading wordpress-installable-build-pr17340-c2bf8ce.apk

	💡 Scan this QR code with your Android phone to download and install the APK directly on it.
	App	WordPress
	Build Flavor	Jalapeno
	Build Type	Debug
	Commit	c2bf8ce

Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

[wpmobilebot]

📲 You can test these changes on Jetpack by downloading jetpack-installable-build-pr17340-de70a62.apk

	💡 Scan this QR code with your Android phone to download and install the APK directly on it.
	App	Jetpack
	Build Flavor	Jalapeno
	Build Type	Debug
	Commit	de70a62

Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

[AliSoftware]

👋 @AliSoftware !

If I am not mistaken, the new fastlane/metadata/android/en-US/changelogs/1281.txt file is missing, can you confirm that? 🤔

What an eagle eye! Thanks so much for noticing that, you're a life-saver!

I also checked at what I submitted to Play Store, and indeed the <en-US>…</en-US> entry of the release notes were empty as a result, so indeed we almost submitted a release with no English release notes (and with the default ones falling back to the Arabic ones instead, apparently)!

The root cause of this bug is likely due to the same issue that what happened in a 20.6 too (see pdnsEh-jJ-p2#comment-1233), where the en-GB translation were missing for the release notes, and since we currently do something very ugly with mapping the source copy of the en-GB locale to retrieve the en-US's changelogs/*.txt, and if there is no en-GB entry in GlotPress for a release… then the entire entry is absent from the GlotPress download, hence why we fail to extract the associated source file from it.

We should definitively remove that en-GB => en-US hacky mapping at some point, and instead copy the files from the WordPress/metadata/*.txt source of truth like we do for the case of Jetpack. I'll try to address that in a dedicated PR on trunk.

Note: Ideally in the future we could even consider having fastlane/*metadata/en-US (or even fastlane/*metadata/default) be the source of truth, instead of it being WordPress/*metadata and then having to copy that over to fastlane/*metadata/en-US during final release, that would simplify things greatly. The case for release_notes.txt is a bit special though, as at some point during the release that file contains transient content (the release notes extracted from the top section of RELEASE-NOTES.txt, before they get editorialized), so that wouldn't solve us keeping to have a separate, transient source of truth for that one I guess?

[AliSoftware]

👋 @AliSoftware !

If I am not mistaken, the new fastlane/metadata/android/en-US/changelogs/1281.txt file is missing, can you confirm that? 🤔

Fixed in c2bf8ce, and manually updated the Release Notes in Play Store Console accordingly as well, which now defaults back to en-US 🎉

[ParaskP7]

What an eagle eye! Thanks so much for noticing that, you're a life-saver!

🦅 👀

I also checked at what I submitted to Play Store, and indeed the <en-US>…</en-US> entry of the release notes were empty as a result, so indeed we almost submitted a release with no English release notes!

Good thinking, nice catch! 🥇

(and with the default ones falling back to the Arabic ones instead, apparently)

😵‍💫

The root cause of this bug is likely due to the same issue that what happened in a 20.6 too (see pdnsEh-jJ-p2#comment-1233), where the en-GB translation were missing for the release notes, and since we currently do something very ugly with mapping the source copy of the en-GB locale to retrieve the en-US's changelogs/*.txt, and if there is no en-GB entry in GlotPress for a release… then the entire entry is absent from the GlotPress download, hence why we fail to extract the associated source file from it.

👀

We should definitively remove that en-GB => en-US hacky mapping at some point, and instead copy the files from the WordPress/metadata/*.txt source of truth like we do for the case of Jetpack. I'll try to address that in a dedicated PR on trunk.

👍 💯

Note: Ideally in the future we could even consider having fastlane/*metadata/en-US (or even fastlane/*metadata/default) be the source of truth, instead of it being WordPress/*metadata and then having to copy that over to fastlane/*metadata/en-US during final release, that would simplify things greatly. The case for release_notes.txt is a bit special though, as at some point during the release that file contains transient content (the release notes extracted from the top section of RELEASE-NOTES.txt, before they get editorialized), so that wouldn't solve us keeping to have a separate, transient source of truth for that one I guess?

Thanks for this note! 🙇

[ParaskP7]

LGTM! 💯

Fixed in c2bf8ce, and manually updated the Release Notes in Play Store Console accordingly as well, which now defaults back to en-US 🎉

Awesome, thanks for the double fix @AliSoftware ! 🥇 ❤️ 🚀

[AliSoftware]

We should definitively remove that en-GB => en-US hacky mapping at some point, and instead copy the files from the WordPress/metadata/*.txt source of truth like we do for the case of Jetpack. I'll try to address that in a dedicated PR on trunk.

Follow-up on this: #17341