Add dark mode support for Zendesk tickets screen #22537
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Override Zendesk SDK colors in night resources to properly support dark mode: - Background colors for list and empty states - Text colors with appropriate alpha values - Message bubble colors for agent and user messages - Input hint and button inactive colors - Night layout for empty state with theme-aware text color Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Use existing white_translucent_* colors instead of hard-coded hex values for better maintainability and consistency with the codebase. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Collaborator
Generated by 🚫 Danger |
Add tools:override="true" to indicate these colors intentionally override Zendesk SDK resources for dark mode support. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This reverts commit 18bbef2.
These colors only need night mode overrides because the base values are provided by the Zendesk SDK. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
|
|
Contributor
|
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
These colors override Zendesk SDK resources for dark mode but lint cannot detect their usage within the SDK. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Change parent style from WordPress.NoActionBar to WordPress.NoActionBar.NoEdgeToEdge to prevent content from drawing under the system bars. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Contributor
Author
|
Unfortunately, although we can override the colors in the default layout, once messages are showing they appear as white-on-white in dark mode. I did not see a way to resolve this, and Claude made several failed attempts as well. 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes CMM-167
Override Zendesk SDK colors in night resources to properly support dark mode: